Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC20Bridgeable: An ERC-7802 implementation #27

Merged
merged 116 commits into from
Dec 13, 2024
Merged

Add ERC20Bridgeable: An ERC-7802 implementation #27

merged 116 commits into from
Dec 13, 2024

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented Nov 28, 2024

Description

This is an experiment to test how to use an ERC-7786 to create a gateway for cross-chain tokens following ERC-7802.

@ernestognw ernestognw requested a review from frangio December 10, 2024 18:56
@ernestognw
Copy link
Member Author

Oh god

Captura de pantalla 2024-12-10 a la(s) 12 57 35 p m

@@ -49,28 +48,23 @@
"@nomicfoundation/hardhat-chai-matchers": "^2.0.6",
"@nomicfoundation/hardhat-ethers": "^3.0.5",
"@nomicfoundation/hardhat-network-helpers": "^1.0.11",
"@openzeppelin/contracts": "file:lib/@openzeppelin-contracts",
Copy link
Collaborator

@Amxx Amxx Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side effect, this will get all the dependencies that are already present in the main repo.

That means we could technically remove anything we have in devDependencies that is not exclusive to the community repo. Do we want to do that ?

Amxx
Amxx previously approved these changes Dec 12, 2024
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all tests pass, then that version is good for me.

Note: solhint will not be happy with some of the stuff in the mocks, but we'll see that when we enable it.

@ernestognw ernestognw merged commit e6c66b6 into master Dec 13, 2024
10 checks passed
@Amxx Amxx deleted the erc7802 branch December 13, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants