Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inheritance ordering checks #37

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

ernestognw
Copy link
Member

No description provided.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for community-contracts ready!

Name Link
🔨 Latest commit 34d0c96
🔍 Latest deploy log https://app.netlify.com/sites/community-contracts/deploys/67576f748ef424000894ba8d
😎 Deploy Preview https://deploy-preview-37--community-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ernestognw ernestognw marked this pull request as ready for review December 10, 2024 17:39
@ernestognw ernestognw requested a review from a team as a code owner December 10, 2024 17:39
@ernestognw
Copy link
Member Author

Merging after discussing internally. We think this covers enough compatibility with OpenZeppelin Contracts since it already imports the relevant contracts.

@ernestognw ernestognw merged commit 72ebcd5 into master Dec 10, 2024
10 checks passed
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to improve it to add all of the main repo into the ordering, but that is a good start

@Amxx
Copy link
Collaborator

Amxx commented Dec 10, 2024

Here the relevant are governor. It is currently not imported :/

@ernestognw
Copy link
Member Author

Yes. I added this to our 2025 wishlist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants