Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EIP712 dependency from AccountCore to Account #58

Merged
merged 8 commits into from
Jan 13, 2025

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 6, 2025

As discussed during todays call, some account implementation may "vertically integrate" with the signer in a way were they raw sign the userOpHash (or similar).

Optional: we could remove the "default implementation" of _signableUserOpHash from AccountCore.

@Amxx Amxx marked this pull request as ready for review January 6, 2025 17:03
@Amxx Amxx requested a review from a team as a code owner January 6, 2025 17:03
@ernestognw
Copy link
Member

we could remove the "default implementation" of _signableUserOpHash from AccountCore.

I'm not sure since this is in the middle of validateUserOp, which makes it difficult to replace without overriding the whole validation

ernestognw
ernestognw previously approved these changes Jan 9, 2025
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg! 🚀

@Amxx
Copy link
Collaborator Author

Amxx commented Jan 13, 2025

we could remove the "default implementation" of _signableUserOpHash from AccountCore.

I'm not sure since this is in the middle of validateUserOp, which makes it difficult to replace without overriding the whole validation

I did not mean to remove the function definition. I meant to keep the function definition, but without an implementation.

    function _signableUserOpHash(
        PackedUserOperation calldata userOp,
        bytes32 userOpHash
    ) internal view virtual returns (bytes32);

@Amxx Amxx requested a review from ernestognw January 13, 2025 15:58
@ernestognw ernestognw merged commit c1248a5 into master Jan 13, 2025
12 checks passed
@Amxx Amxx deleted the aa/move-eip712-to-account branch January 14, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants