-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move EIP712 dependency from AccountCore to Account #58
Conversation
Co-authored-by: Hadrien Croubois <[email protected]>
I'm not sure since this is in the middle of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lfg! 🚀
I did not mean to remove the function definition. I meant to keep the function definition, but without an implementation. function _signableUserOpHash(
PackedUserOperation calldata userOp,
bytes32 userOpHash
) internal view virtual returns (bytes32); |
As discussed during todays call, some account implementation may "vertically integrate" with the signer in a way were they raw sign the userOpHash (or similar).
Optional: we could remove the "default implementation" of
_signableUserOpHash
fromAccountCore
.