Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove devDependency lerna #972

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Remove devDependency lerna #972

merged 4 commits into from
Feb 16, 2024

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Feb 14, 2024

Closes #929

@ericglau ericglau requested a review from a team February 14, 2024 20:11
@ernestognw
Copy link
Member

Seems like there are also breaking changes for 7.0.

Have you run lerna repair?

@ericglau ericglau changed the title Update devDependency lerna to v7 Update devDependency lerna to v8 Feb 16, 2024
@ericglau
Copy link
Member Author

Updated to lerna 8, removed unneeded/incompatible dependency, and ran lerna repair.

Copy link

socket-security bot commented Feb 16, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ericglau
Copy link
Member Author

ericglau commented Feb 16, 2024

I think we can remove the dependency altogether. We mainly use lerna for publishing, but since we only have 2 packages at this point (core and hardhat-upgrades), we can publish them individually.

@ericglau ericglau changed the title Update devDependency lerna to v8 Remove devDependency lerna Feb 16, 2024
@ernestognw
Copy link
Member

I think we can remove the dependency altogether. We mainly use lerna for publishing, but since we only have 2 packages at this point (core and hardhat-upgrades), we can publish them individually.

Sounds good to me for now. We might reconsider if we ever release something for the incoming Stylus library (EVM compatible)

@ericglau ericglau merged commit dd8c414 into OpenZeppelin:master Feb 16, 2024
13 checks passed
@ericglau ericglau deleted the lerna branch February 16, 2024 22:04
@ericglau ericglau mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants