-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ERC-4626 extension #465
feat: ERC-4626 extension #465
Conversation
✅ Deploy Preview for contracts-stylus ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I just stared this |
I'll convert this to a draft, so that the team does not invest time reviewing a WIP |
@0xNeshi SafeERC20.safeTransferFrom(_asset, caller, address(this), assets); In the Solidity implementation, |
See how VestingWallet handles this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job guys!
Left a few comments
… convert_to_shares
I made Aside from enabling devs to override the decimals offset value, I was able to add additional test cases verifying what happens if this value overflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Resolves #356
PR Checklist