Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protocol-designer): start of cypress happy path test for mix settings #17320

Merged
merged 40 commits into from
Feb 11, 2025

Conversation

skowalski08
Copy link
Contributor

@skowalski08 skowalski08 commented Jan 22, 2025

Overview

Cypress happy path testing for mix settings. Still in progress, have test cases through Mix Settings Part 2 / 2 Aspirate settings.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Copy link
Contributor

@alexjoel42 alexjoel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really thoughtful and thorough test coverage. Once we have alignment on some locators, fix a few bugs, and get Josh's likely much more thorough review it looks good to me!

cypress.config.ts Outdated Show resolved Hide resolved
Actions.SelectTipHandling,
UniversalActions.Snapshot,
Actions.Continue,
Verifications.PartTwoAsp,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was really impressed by how thorough your verifications were!

cypress/fixtures/example.json Outdated Show resolved Hide resolved
cypress/support/commands.ts Outdated Show resolved Hide resolved
cypress/support/e2e.ts Outdated Show resolved Hide resolved
protocol-designer/cypress/e2e/mixSettings.cy.ts Outdated Show resolved Hide resolved
cy.contains(Content.OnceAtStartStep).click()
break
case Actions.AspirateFlowRate:
cy.get(Locators.Aspirate).should('exist').should('be.visible').click()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should work, but I'd want to check with Devs how stable these locators are. I have a decent amount of them in my code as well so would be good to find out!

protocol-designer/cypress/support/commands.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0.16978% with 588 lines in your changes missing coverage. Please review.

Project coverage is 26.13%. Comparing base (455774e) to head (e65af76).
Report is 5 commits behind head on edge.

Files with missing lines Patch % Lines
protocol-designer/cypress/support/mixSetting.ts 0.20% 492 Missing ⚠️
protocol-designer/cypress/e2e/mixSettings.cy.ts 0.00% 62 Missing ⚠️
protocol-designer/cypress/support/commands.ts 0.00% 19 Missing ⚠️
protocol-designer/cypress.config.ts 0.00% 9 Missing ⚠️
protocol-designer/cypress/support/StepExecution.ts 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17320      +/-   ##
==========================================
- Coverage   26.16%   26.13%   -0.04%     
==========================================
  Files        3191     3195       +4     
  Lines      230143   230858     +715     
  Branches     9808     9846      +38     
==========================================
+ Hits        60220    60332     +112     
- Misses     169898   170501     +603     
  Partials       25       25              
Flag Coverage Δ
protocol-designer 17.41% <0.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/cypress/support/StepExecution.ts 0.00% <0.00%> (ø)
protocol-designer/cypress.config.ts 0.00% <0.00%> (ø)
protocol-designer/cypress/support/commands.ts 0.00% <0.00%> (ø)
protocol-designer/cypress/e2e/mixSettings.cy.ts 0.00% <0.00%> (ø)
protocol-designer/cypress/support/mixSetting.ts 0.20% <0.20%> (ø)

... and 5 files with indirect coverage changes

@skowalski08 skowalski08 marked this pull request as ready for review February 7, 2025 19:38
@skowalski08 skowalski08 requested review from a team as code owners February 7, 2025 19:38
@skowalski08 skowalski08 requested review from jerader and removed request for a team February 7, 2025 19:38
Copy link
Contributor

@alexjoel42 alexjoel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Will hand off to @y3rsh and @jerader for the final "go ahead" and once your PR passes the failing checks. We may also want to see how this interacts with the Parametrization work that took place.

@skowalski08 skowalski08 merged commit 4b054ad into edge Feb 11, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants