feat(protocol-designer): start wiring up "Export Python" button to generate Python #17453
+134
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17453 +/- ##
==========================================
- Coverage 20.07% 20.05% -0.02%
==========================================
Files 3187 3194 +7
Lines 229811 230200 +389
Branches 8190 8204 +14
==========================================
+ Hits 46132 46171 +39
- Misses 183679 184029 +350
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
reviewed
Feb 7, 2025
| @@ -47,6 +47,7 @@ import type { | |||
| import type { LabwareDefByDefURI } from '../../labware-defs' | |||
| import type { Selector } from '../../types' | |||
| import type { PDMetadata } from '../../file-types' | |||
| import { pythonImports, pythonMetadata } from './pythonFile' | |||
There was a problem hiding this comment.
can this import go above the types? 😄
not sure if you were told our preferred import order but we like to do it like:
- dependencies
- top level imports from other projects like
@opentrons/components - local paths furtherest away to closest so like
../.../should go above../ - types (types follow the same pattern as a non type)
There was a problem hiding this comment.
Ah, I wasn't aware of that preferred order, thanks!
jerader
approved these changes
Feb 7, 2025
caila-marashaj
pushed a commit
that referenced
this pull request
Feb 11, 2025
…nerate Python (#17453) # Overview Make the "Export Python" button start generating the skeleton of a Python protocol file. This just generates the `metadata` section right now. AUTH-1091 AUTH-1393 AUTH-1385 I tried to follow the structure of the existing `createFile()` function. Eventually, the `createPythonFile()` function is just going to replace `createFile()`, so that's why I'm reusing the existing `SAVE_PROTOCOL_FILE` action rather than defining a bunch of new Python-specific constants and interfaces. ## Test Plan and Hands on Testing Added unit tests for both the top-level file creator, and for the specific metadata fields. I also tested the button in my browser. ## Risk assessment Low. This is all hidden behind a feature flag, and doesn't interact with any existing functionality.
TamarZanzouri
pushed a commit
that referenced
this pull request
Feb 11, 2025
…nerate Python (#17453) # Overview Make the "Export Python" button start generating the skeleton of a Python protocol file. This just generates the `metadata` section right now. AUTH-1091 AUTH-1393 AUTH-1385 I tried to follow the structure of the existing `createFile()` function. Eventually, the `createPythonFile()` function is just going to replace `createFile()`, so that's why I'm reusing the existing `SAVE_PROTOCOL_FILE` action rather than defining a bunch of new Python-specific constants and interfaces. ## Test Plan and Hands on Testing Added unit tests for both the top-level file creator, and for the specific metadata fields. I also tested the button in my browser. ## Risk assessment Low. This is all hidden behind a feature flag, and doesn't interact with any existing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make the "Export Python" button start generating the skeleton of a Python protocol file. This just generates the
metadatasection right now. AUTH-1091 AUTH-1393 AUTH-1385I tried to follow the structure of the existing
createFile()function. Eventually, thecreatePythonFile()function is just going to replacecreateFile(), so that's why I'm reusing the existingSAVE_PROTOCOL_FILEaction rather than defining a bunch of new Python-specific constants and interfaces.Test Plan and Hands on Testing
Added unit tests for both the top-level file creator, and for the specific metadata fields.
I also tested the button in my browser.
Risk assessment
Low. This is all hidden behind a feature flag, and doesn't interact with any existing functionality.