Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to Make dropdown menu with color features like FOSSASIA.org and also enable expansion of menu #7

Merged
merged 5 commits into from
Dec 27, 2019
Merged

PR to Make dropdown menu with color features like FOSSASIA.org and also enable expansion of menu #7

merged 5 commits into from
Dec 27, 2019

Conversation

makoteq
Copy link
Contributor

@makoteq makoteq commented Dec 21, 2019

fixed for #3
Link to preview : https://makoteq.github.io/opentechsummit.eu/

@makoteq makoteq force-pushed the gh-pages branch 2 times, most recently from 4a51681 to f92d575 Compare December 21, 2019 19:20
@makoteq
Copy link
Contributor Author

makoteq commented Dec 21, 2019

@mariobehling

@mariobehling
Copy link
Member

This does not solve the issue. The current CSS needs to be updated with the feature required.

mariobehling
mariobehling requested changes Dec 22, 2019
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the current theme css and update the feature.

@makoteq
Copy link
Contributor Author

makoteq commented Dec 23, 2019 •
edited
Loading

What about now? @mariobehling

@mariobehling
Copy link
Member

I recommend you work together with your co-contributor on the issue. Indent and spacing was changed and it should not be changed. Only color overlay on scroll-over should be changed.

Please compare here: #5 (comment)

Please help me here. I am making the same comments in different PRs. It is not a good use of time to repeat the same thing in different PRs. Please work together!

@makoteq
Copy link
Contributor Author

makoteq commented Dec 23, 2019

@mariobehling I'll follow this other PR, sorry for problem

@makoteq
Copy link
Contributor Author

makoteq commented Dec 23, 2019

@mariobehling I removed changes in spacing and I changed the hover color

mariobehling
mariobehling requested changes Dec 24, 2019
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing in dropdown changed and menu items missing.

Screenshot from 2019-12-24 03-58-54

Expected: The spacing should not change and all menu items should be there.

@mariobehling mariobehling changed the title add link to theme-lava PR to Make dropdown menu with color features like FOSSASIA.org and also enable expansion of menu Dec 24, 2019
@makoteq
Copy link
Contributor Author

makoteq commented Dec 24, 2019 •
edited
Loading

I removed max-height, and padding for menu so now it should be ok
New link to preview https://makoteq.github.io/opentechsummit.eu.custom/
@mariobehling

@makoteq
Copy link
Contributor Author

makoteq commented Dec 25, 2019

@mariobehling what about now?

@mariobehling
Copy link
Member

Still not as expected. Please compare exactly with fossasia.org

mariobehling
mariobehling approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@mariobehling mariobehling merged commit 79e1362 into OpnTec:gh-pages Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makoteq @mariobehling