Upgrading Spinnaker from 1.33.2 to 1.33.3 #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devopsmx.atlassian.net/browse/OP-22347
Parent Jira: https://devopsmx.atlassian.net/browse/OP-22345
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
Helpful Tips
Add screenshots and annotations
Add a gif to show an action
GIFs are great to show an action, however they sometimes move too fast.
One way to improve them is to capture 3 pieces of content:
Put a border around a screenshot/gif
Add a border to help improve the readability.
Add expandable sections
Add expandable sections to hide away large code blocks/images or reduce the motion of a gifs