Google Secrets Manager Support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pinnaker#884) Co-authored-by: David Byron <[email protected]> Co-authored-by: Cameron Motevasselani <[email protected]>
…pinnaker#887) (spinnaker#899) Co-authored-by: j-sandy <jsandy> Co-authored-by: Sandesh <[email protected]>
…ort spinnaker#888) (spinnaker#900) Co-authored-by: j-sandy <jsandy> Co-authored-by: Sandesh <[email protected]> Co-authored-by: Cameron Motevasselani <[email protected]>
…ackport spinnaker#891) (spinnaker#901) Co-authored-by: j-sandy <jsandy> Co-authored-by: Sandesh <[email protected]> Co-authored-by: Cameron Motevasselani <[email protected]>
…CVE (backport spinnaker#892) (spinnaker#902) Co-authored-by: j-sandy <jsandy> Co-authored-by: Sandesh <[email protected]> Co-authored-by: Cameron Motevasselani <[email protected]>
…pinnaker#897) (spinnaker#903) Co-authored-by: Cristhian Castaneda <[email protected]>
Co-authored-by: Cameron Motevasselani <[email protected]> (cherry picked from commit bd19fe4) Co-authored-by: Cameron Motevasselani <[email protected]>
…spinnaker#925) When we moved to Jackson 2.12 there were some constructors that weren't updated and weren't caught until runtime. I don't know enough about Jackson's Kotlin integration to why this wasn't an issue. I built and ran tests on master for this project and everything was fine, even after making the constructor changes. I tested this change by using composite builds to bring this into rosco and see that it starts successfully now. I'm not sure if we'll need to do similar kork bumps in other services. (cherry picked from commit de24322) Co-authored-by: Fernando Freire <[email protected]>
- SecretEngine interface implementation class. - Test cases for implementation class. - Gradle dependency changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Secrets manager support in Kork Library.