V1 of django-pgmigrate
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the PR will fail until django-pglock V1 is deployed |
| * Detect blocking queries and terminate them automatically. | ||
| * Print blocking queries so that you can inspect | ||
| and terminate them manually. | ||
| * Set the lock timeout so that migrations are terminated if they block too long. |
There was a problem hiding this comment.
Production experience makes me think having the statement timeout around a migration would be useful too. I have often seen devs push code where the migration easily gets the lock, but the migration itself ends up taking much longer than expected/taking locks in areas one would not expect (thus can end up blocking all other queries). Having the statement timeout here is a good fall back.
There was a problem hiding this comment.
Yea I think that would be a nice configuration option. I added a feature request to the issue board - #2
Should be easy to add. Just trying to keep the first PR small
wesleykendall
force-pushed
the
v1
branch
3 times, most recently
from
675e103
to
9e96c25
Compare
``django-pgmigrate`` helps you avoid costly downtime with Postgres migrations and provides the following features to alleviate problematic locking scenarios when running migrations: * Detect blocking queries and terminate them automatically. * Print blocking queries so that you can inspect and terminate them manually. * Set the lock timeout so that migrations are terminated if they block too long. Type: api-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-pgmigratehelps you avoid costly downtime with Postgres migrations and provides the following features to alleviate problematic locking scenarios when running migrations:Type: api-break