Skip to content

Commit

Permalink
Merge pull request #717 from Orange-OpenSource/715-bug-accessibility-…
Browse files Browse the repository at this point in the history
…some-elements-are-not-vocalised-correctly

715 - Accessibility - Fix bad vocalization for top app bar change theme button
  • Loading branch information
florentmaitre authored Nov 27, 2023
2 parents 1bf4ab2 + 26ccf51 commit ff58af3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/src/main/java/com/orange/ods/app/ui/AppBarActions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ private fun getSearchAction(onClick: (AppBarAction) -> Unit) = OdsTopAppBar.Acti
private fun getChangeThemeAction(onClick: (AppBarAction) -> Unit) = OdsTopAppBar.ActionButton(
onClick = { onClick(AppBarAction.ChangeTheme) },
painter = painterResource(id = R.drawable.ic_palette),
contentDescription = stringResource(id = R.string.top_app_bar_action_change_mode_to_dark_desc)
contentDescription = stringResource(id = R.string.top_app_bar_action_change_theme_desc)
)

@Composable
Expand Down
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- \[App\] Fix nested class names in code implementation ([#708](https://github.com/Orange-OpenSource/ods-android/issues/708))
- \[App\] Fix bad vocalization for top bar change theme button ([#715](https://github.com/Orange-OpenSource/ods-android/issues/715))
- \[Lib\] Fix back button color in `OdsLargeTopAppBar` ([#685](https://github.com/Orange-OpenSource/ods-android/issues/685))
- \[Lib\] Fix a bug where the modifier was not taken into account in `OdsPasswordTextField` ([#710](https://github.com/Orange-OpenSource/ods-android/issues/710))

Expand Down

0 comments on commit ff58af3

Please sign in to comment.