-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#285] Fix VoiceOver issue with element grouping in presentation tokens for demo app #292
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le CHANGELOG n'est pas bon.
CHANGELOG.md
Outdated
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
### Fixed | |||
|
|||
- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens ([#212](https://github.com/Orange-OpenSource/ouds-ios/issues/285)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cette ligne n'a rien à faire dans la section pour la v0.6.0 qui a été livrée.
Il doit être dans une sous-section "Fixed" dans la section "Unreleased", je t'ai déjà fait la remarque la semaine dernière.
CHANGELOG.md
Outdated
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
### Fixed | |||
|
|||
- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens ([#212](https://github.com/Orange-OpenSource/ouds-ios/issues/285)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je note que ta PR modifie d'une part effectivement l'a11y mais aussi met à jour la déclaration d'accessibiltié.
Comme j'ai déjà pu te le dire, il faut que ton CHANGELOG reflète ce qu'apporte ta PR.
Change la ligne du CHANGELOG pour indiquer que tu mets à jour la déclaration (en plus de corriger ton bug).
3d06603
to
72e56d1
Compare
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Description
Motivation & Context
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)