Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#285] Fix VoiceOver issue with element grouping in presentation tokens for demo app #292

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Tayebsed93
Copy link
Collaborator

@Tayebsed93 Tayebsed93 commented Nov 15, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibiltiy review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@pylapp pylapp self-assigned this Nov 18, 2024
@pylapp pylapp changed the title 285 demoapp fix voiceover issue with element grouping in presentation tokens a11y [#285] Fix VocieOver issue with element grouping in presentation tokens for demo app Nov 18, 2024
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le CHANGELOG n'est pas bon.

CHANGELOG.md Outdated
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens ([#212](https://github.com/Orange-OpenSource/ouds-ios/issues/285))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette ligne n'a rien à faire dans la section pour la v0.6.0 qui a été livrée.
Il doit être dans une sous-section "Fixed" dans la section "Unreleased", je t'ai déjà fait la remarque la semaine dernière.

CHANGELOG.md Outdated
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- [DemoApp] Fix VoiceOver issue with element grouping in presentation tokens ([#212](https://github.com/Orange-OpenSource/ouds-ios/issues/285))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je note que ta PR modifie d'une part effectivement l'a11y mais aussi met à jour la déclaration d'accessibiltié.
Comme j'ai déjà pu te le dire, il faut que ton CHANGELOG reflète ce qu'apporte ta PR.
Change la ligne du CHANGELOG pour indiquer que tu mets à jour la déclaration (en plus de corriger ton bug).

@pylapp pylapp changed the title [#285] Fix VocieOver issue with element grouping in presentation tokens for demo app [#285] Fix VoiceOver issue with element grouping in presentation tokens for demo app Nov 18, 2024
@Tayebsed93 Tayebsed93 force-pushed the 285-demoapp-fix-voiceover-issue-with-element-grouping-in-presentation-tokens-a11y branch from 3d06603 to 72e56d1 Compare November 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DemoApp] Fix VoiceOver issue with element grouping in presentation tokens (a11y)
2 participants