#7412: Verified and added several Cloning overrides in many drivers #7592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Mar 2, 2017
| @@ -177,5 +177,11 @@ public class AutoroutePartDriver : ContentPartDriver<AutoroutePart> { | |||
| context.Element(part.PartDefinition.Name).SetAttributeValue("UseCulturePattern", part.Record.UseCulturePattern); | |||
| context.Element(part.PartDefinition.Name).SetAttributeValue("PromoteToHomePage", part.PromoteToHomePage); | |||
| } | |||
|
|
|||
| protected override void Cloning(AutoroutePart originalPart, AutoroutePart clonePart, CloneContentContext context) { | |||
| clonePart.CustomPattern = originalPart.CustomPattern; | |||
There was a problem hiding this comment.
Is it the actual slug? If so it should be altered.
There was a problem hiding this comment.
No. That would be the DisplayAlias property.
|
Looks good but we need someone to confirm it works. /cc summoning @BenedekFarkas |
|
I'll be happy to do testing on this and the related PRs, but won't be able to do so in the next few days. I'll add myself as a reviewer just in case, so it shows up for me on GitHub. |
…Cleanup # Conflicts: # src/Orchard.Web/Core/Contents/Views/Parts.Contents.Publish.SummaryAdmin.cshtml # src/Orchard.Web/Modules/Orchard.MediaLibrary/Drivers/AudioPartDriver.cs # src/Orchard.Web/Modules/Orchard.MediaLibrary/Drivers/DocumentPartDriver.cs # src/Orchard.Web/Modules/Orchard.MediaLibrary/Drivers/MediaPartDriver.cs # src/Orchard.Web/Modules/Orchard.MediaLibrary/Drivers/OEmbedPartDriver.cs
BenedekFarkas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7412
I am not sure all the overrides are correct even here.
I added the Cloning override in some of the drivers that did not have it as well.