Small optimization in TaxonomyService #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| public ILogger Logger { get; set; } | ||
| public Localizer T { get; set; } | ||
|
|
||
| private IEnumerable<TaxonomyPart> _taxonomies; |
There was a problem hiding this comment.
Suggested change
| private IEnumerable<TaxonomyPart> _taxonomies; | |
| private List<TaxonomyPart> _taxonomies; |
Since the type is known and this is a private member
There was a problem hiding this comment.
Unless it's not what the method returns
There was a problem hiding this comment.
IContentQuery<T>.List() (which is what's assigned and eventually returned here) returns an IEnumerable<T>. Definitely not a List<T>.
sebastienros
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memorize results of queries to prevent repeated execution within a request.
We noticed a few instances where the same query would be invoked several times in the same request. For example, when several contentItems of a same contentType are in the same list.
This allows skipping a few of those queries.