-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 #14256
base: main
Are you sure you want to change the base?
Vue 3 #14256
Conversation
# Conflicts: # src/docs/resources/libraries/README.md
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/package.json
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/package.json
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/package.json # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.js # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/trumbowyg-plugins.min.js # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Styles/trumbowyg-plugins.css # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Styles/trumbowyg-plugins.min.css # src/docs/resources/libraries/README.md
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.js # src/OrchardCore.Modules/OrchardCore.Media/wwwroot/Scripts/media.min.js
remove depends-on="admin"
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Resources/package.json
Thanks for the update! |
Happy to support that from our end.
I would suggest not trying to use a generated client here. Obviously I have an nswag module, which is fine to use, or bring into OC, but it doesn't fix the above problem. |
I can generate the client and remove what is not needed for the file app manually. But, yeah, that's a downside. |
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Cors/Views/Admin/Index.cshtml # src/OrchardCore.Modules/OrchardCore.Media/Assets.json # src/OrchardCore.Modules/OrchardCore.Media/ResourceManifestOptionsConfiguration.cs # src/OrchardCore.Modules/OrchardCore.Media/Startup.cs # src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs # src/OrchardCore.Modules/OrchardCore.Resources/package.json # src/OrchardCore.Modules/OrchardCore.Workflows/Views/Items/CorrelateTask.Fields.Edit.cshtml # src/OrchardCore.Themes/TheAdmin/ResourceManagementOptionsConfiguration.cs
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/PlaceholderAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.ContentFields/Views/ContentPickerField.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.ContentFields/Views/LocalizationSetContentPickerField.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.ContentFields/Views/MultiTextField-Picker.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.ContentFields/Views/MultiTextFieldSettings.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.ContentFields/Views/TextFieldPredefinedListEditorSettings.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.ContentFields/Views/UserPickerField.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.ContentFields/Views/UserPickerFieldSettings.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/ContentTypesAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.Cors/Views/Admin/Index.cshtml # src/OrchardCore.Modules/OrchardCore.Forms/Views/Items/SelectPart.Fields.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.Lists/Views/Items/ListsAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.Media/PermissionProvider.cs # src/OrchardCore.Modules/OrchardCore.OpenId/Views/OpenIdClientSettings.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs # src/OrchardCore.Modules/OrchardCore.Seo/Views/SeoMetaPart.Edit.cshtml # src/OrchardCore.Modules/OrchardCore.Shortcodes/Views/Admin/Create.cshtml # src/OrchardCore.Modules/OrchardCore.Shortcodes/Views/Admin/Edit.cshtml # src/OrchardCore.Modules/OrchardCore.Taxonomies/Views/TaxonomyField-Tags.Edit.cshtml
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/LinkAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Items/PlaceholderAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.Contents/Views/Items/ContentTypesAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.Lists/Views/Items/ListsAdminNode.Fields.TreeEdit.cshtml # src/OrchardCore.Modules/OrchardCore.Media/GulpAssets.json # src/OrchardCore.Modules/OrchardCore.Media/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/Assets.json # src/OrchardCore.Modules/OrchardCore.Resources/Assets/package.json # src/OrchardCore.Modules/OrchardCore.Resources/ResourceManagementOptionsConfiguration.cs # src/OrchardCore.Modules/OrchardCore.Resources/package-lock.json # src/OrchardCore.Modules/OrchardCore.Resources/wwwroot/Scripts/vue-multiselect.min.js # src/OrchardCore.Themes/TheTheme/Assets/package.json # yarn.lock
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # yarn.lock
Work in progress.
The goal here is first to migrate all the components and SFC to Vue 3. We cannot use
new Vue
with Vue 3 so some components will need to be refactored.Also, the components dynamic loading methods need to be removed in favor of using a wrapping component with props simply. Favor usage of Vite with Vue 3 apps/components.
Tasks
Fixes #7110.
Optional
Consider refactoring upload bits by using Uppy instead of JQuery FileUpload as it is now archived and old.
See:
https://uppy.io/
https://tus.io/
https://github.com/tusdotnet/tusdotnet
https://www.ietf.org/archive/id/draft-tus-httpbis-resumable-uploads-protocol-00.html