-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions actions to the latest versions #15619
Conversation
Would you like some assistance here? |
I have not had much time to revisit this. Feel free to make changes if you have time. |
What did you attempt with |
Why I'm asking is because I looked at the commit log and am confused, given that in the end you reverted all changes. |
yes. that's because the changes I tried did not work. I had no time to dig more, so I reverted my changes meanwhile. |
Let me check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are failing but with this: #15628. Otherwise, the update is good.
This reverts commit ba789ef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rightfully fails since it notices issues, but otherwise works correctly: #15726
Done, could you please review? |
@Piedone did you run the workflows? Everything worked without warning? Why did the .svg file change? |
Yep, except for Contributor Map, see my comments above, but not all of them are running to completion, also see my comments above. You changed the SVG file :). When running the Contributor Map workflow. |
@Piedone LGTM. If you are good with it, feel free to merge it. |
OK then! Contributor Map updated too, so we don't have any deprecation warnings anymore at all: tunaitis/contributor-map#9. |
Fix #15553