Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions actions to the latest versions #15619

Merged
merged 28 commits into from
Apr 11, 2024
Merged

Conversation

MikeAlhayek
Copy link
Member

Fix #15553

@Piedone Piedone changed the title Update Workflow actions to the latest versions Update GitHub Actions actions to the latest versions Mar 28, 2024
@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

Would you like some assistance here?

@MikeAlhayek
Copy link
Member Author

I have not had much time to revisit this. Feel free to make changes if you have time.

@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

What did you attempt with asset_validation?

@MikeAlhayek
Copy link
Member Author

@Piedone look at the commit log. I tried few things. This one should have fixed it but causes another issue

fdc5a08

@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

Why I'm asking is because I looked at the commit log and am confused, given that in the end you reverted all changes.

@MikeAlhayek
Copy link
Member Author

yes. that's because the changes I tried did not work. I had no time to dig more, so I reverted my changes meanwhile.

@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

Let me check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are failing but with this: #15628. Otherwise, the update is good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rightfully fails since it notices issues, but otherwise works correctly: #15726

@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

Done, could you please review?

@MikeAlhayek
Copy link
Member Author

@Piedone did you run the workflows? Everything worked without warning?

Why did the .svg file change?

@Piedone
Copy link
Member

Piedone commented Apr 11, 2024

Yep, except for Contributor Map, see my comments above, but not all of them are running to completion, also see my comments above.

You changed the SVG file :). When running the Contributor Map workflow.

@MikeAlhayek
Copy link
Member Author

@Piedone LGTM. If you are good with it, feel free to merge it.

@Piedone
Copy link
Member

Piedone commented Apr 11, 2024

OK then! Contributor Map updated too, so we don't have any deprecation warnings anymore at all: tunaitis/contributor-map#9.

@Piedone Piedone merged commit 4d89c70 into main Apr 11, 2024
5 checks passed
@Piedone Piedone deleted the ma/update-workflows branch April 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitHub Actions actions to adapt to Node 16 deprecation
2 participants