Fix JsonDynamicArray enumeration in dynamic usages #16246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
Jun 5, 2024
src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicArray.cs
Outdated
Show resolved
Hide resolved
…micArray.cs Co-authored-by: Mike Alhayek <[email protected]>
|
Note that there are more issues noted in #16233 which are not yet solved by this PR. |
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
IEnumerable<object>onJsonDynamicArrayand returns that enumerator fromIEnumerable.GetEnumerator(). The existingIEnumerable<JsonNode>is kept, but is now implemented explicitly.Anyone currently using an enumerator from JsonDynamicArray will now by default get an enumerable of objects, which are instances of our dynamic wrappers. Those are also implicitly convertible to
JsonNodeagain, so callers should not lose anything.Address an issue in #16233