-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for net9.0 #16573
base: main
Are you sure you want to change the base?
Add support for net9.0 #16573
Conversation
Is this will be a part of OC |
@hishamco I hope we ship 2.0 before dotnet ships .NET 9 |
There are a few changes we might want to take in 2.0 instead of this PR. Mostly all the code changes (formatting and obsolete method). |
I think we should at least run the build and test the pipeline with .net 9 just to make sure we don't have anything to report. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
7da7af2
to
fe5a020
Compare
This pull request has merge conflicts. Please resolve those before requesting a review. |
@hishamco i suggest that you don't merge main on PR others are constantly working on. Let them do that if they choose to do it "when they are ready for it" |
I just do it when there's a conflict |
I suggest you leave that work for the PR author. Let them work on their own code and resolve their own conflict. |
It's not big, this could happen occasionally, see #4466. I don't know what's the issue if you want anyone update branch in your PRs let me know :) |
This pull request has merge conflicts. Please resolve those before requesting a review. |
resolved conflicts |
This pull request has merge conflicts. Please resolve those before requesting a review. |
@agriffard doing a local |
Ok, thank you, the last change fixed the build. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
but https://www.nuget.org/packages/Microsoft.IdentityModel.Protocols.OpenIdConnect/8.1.0 has been unlisted by the owner |
Main merged and build fixed again. What changed exactly that makes the build fail on warnings like formatting or remaining unnecessary using? |
Static code analyzers are also updated with .NET, so they can warn about previously unnoticed issues. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
308faa4
to
7074e9d
Compare
7074e9d
to
280c351
Compare
Keeping track of all the tasks when adding/removing a TFM (please update so we can document it):
global.json
to the require SDK version.src/OrchardCore.Build/TargetFrameworks.props
.AspNetCorePackagesVersion
for each TFM inDirectory.Packages.props
uses: actions/setup-dotnet@v4
tasks to the required SDK version.dotnet publish
,dotnet build
anddotnet test
calls to the latest TFM, if specified.tasks.json
files to target the latest TFMtemplate.json
files).<TargetFramework>
).