Fix ExternalAuthenticationMigrations namespace

[hishamco]

No description provided.

[MikeAlhayek]

@hishamco you can't rename the migration file or it's name space as this will treat the migration as a new migration and it will run as a new migration (even if the logic ran before).

[hishamco]

Right, that's why I need this for 3.0.0, we need to make everything consistent across the code-base

[MikeAlhayek]

It does not add any value. There is no point of this change which will cause every tenant to run this migration which could potentially case issue with no value added beside a name change.

[hishamco]

This way if there's a historical issue either in migrations or service we can't fix any anymore, that's why major releases open the possibility of breaking things

[gvkries]

I agree with @MikeAlhayek, this is not worth the possible problems.

[hishamco]

That means if we made a mistake accidentally in a previous release, there's no way to fix it. There are many things need to be aligned from the beginning but we hold until a major release, so we don't break anyone

[MikeAlhayek]

@hishamco can we close this?

[hishamco]

I noticed @sebastienros commenting on #17414 and #17189 which are quite similar. I know changing the namespace is critical in this case but I'm still thinking have a proper namespace for APIs is something valuable especially in any frameworks

@sebastienros if you have a better option please let me know, otherwise feel free to close

[gvkries]

This is different from the other PRs, because it is only about an internally used namespace which is not perfect. This namespace is not used anywhere. And additionally it is moving a data migration, which causes updates to the database without a real need.