Fix ExternalAuthenticationMigrations namespace #17370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hishamco you can't rename the migration file or it's name space as this will treat the migration as a new migration and it will run as a new migration (even if the logic ran before). |
|
Right, that's why I need this for |
|
It does not add any value. There is no point of this change which will cause every tenant to run this migration which could potentially case issue with no value added beside a name change. |
|
This way if there's a historical issue either in migrations or service we can't fix any anymore, that's why major releases open the possibility of breaking things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.