Assets Manager doc

[agriffard]

Fixing a few typos in Assets Manager doc.

Trying to execute yarn build -gr (A few files changed).

Not sure about the current phrasing of the last sentence:
Parcel doesn't prevent this and their ESM compiled script will load fine but you should try to avoid it else it is counter productive, you should then use a CommonJS build.
avoid it else it is counter productive Suggestion : avoid it or else it can be counterproductive?

/cc @Skrypt

[agriffard]

Error during build step Validating the Building of Public Assets / Test building assets, as in the Vue 3 PR last build run.

[Skrypt]

Right, that's because the diffviewer.js changes that you pushed doesn't compile the same on CI than on your PC.
Actually everything related with Webpack seems to compile differently on your PC.

[hishamco]

If I'm know wrong @Piedone submitted a PR for fix such issues, right?

[Piedone]

Not yet, just opened #17494.

[Skrypt]

Not sure about the current phrasing of the last sentence: Parcel doesn't prevent this and their ESM compiled script will load fine but you should try to avoid it else it is counter productive, you should then use a CommonJS build. avoid it else it is counter productive Suggestion : avoid it or else it can be counterproductive?

You could try this:

---

Also, Vite by default only allows ES6 builds. Currently it will return a console log if you are trying to integrate its .js builds without the type="module" parameter on their script tag; if not they will throw exceptions from code, so it is mandatory to use type="module" with them.

Parcel allows ES6 builds by configuration in the package.json file by adding the "type": "module" parameter.
If this parameter is not set Parcel will compile as CommonJS.

ESM compiled scripts will load fine on a script tag without "type="module". Though you should try to avoid it.
See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules#applying_the_module_to_your_html

[Skrypt]

Also forgot to add something about using yarn upgrade-interactive if you want to add something @agriffard

[Skrypt]

@agriffard please pull latest main in your branch and rebuild.

[Skrypt]

You did yarn build -gr as part of your last commit?

[agriffard]

@agriffard please pull latest main in your branch and rebuild.

Merge from main done.

yarn build -gr didn't change any files afterwards.
Can you please check?

[agriffard]

You did yarn build -gr as part of your last commit?

I did and no changes detected (only during the process, but not in the end).

[Skrypt]

I will try and pull your branch but ... it seems more like a different configuration on your PC causing this. Normally Webpack should output the same from one PC to an other based on the configs that are set.

[Skrypt]

Or maybe you did not do corepack enable on the root folder. Or it failed doing it.

[agriffard]

Or maybe you did not do corepack enable on the root folder. Or it failed doing it.

corepack enable worked only if I open in Admin mode.

yarn build -gr did not make any changes.

[Skrypt]

We need to find why you get Webpack compilation changes on your PC. I did not get any. I pushed a commit that reverts these changes. All I did was a yarn build -gr which compiled correctly.