Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PoExtractor): add single file output #94

Merged

Conversation

VincenzoCarlino
Copy link
Contributor

Implementation of: #93

Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have few unit tests, there're many corner cases that we need to test, to ensure nothing is broken

src/OrchardCoreContrib.PoExtractor/Program.cs Outdated Show resolved Hide resolved
src/OrchardCoreContrib.PoExtractor/Program.cs Show resolved Hide resolved
src/OrchardCoreContrib.PoExtractor/Program.cs Outdated Show resolved Hide resolved
src/OrchardCoreContrib.PoExtractor/Program.cs Outdated Show resolved Hide resolved
@VincenzoCarlino
Copy link
Contributor Author

It would be nice to have few unit tests, there're many corner cases that we need to test, to ensure nothing is broken

Look at this commit

It's a preview of some kinds of test we can do.
All code is inside the main static function, so we can test it as I've done it in this commit, or we try to extract the code from main in something more testable.
Let me know if you like it.

@hishamco
Copy link
Member

Thanks, @VincenzoCarlino, we might need to test more cases such as if there's a PO file with the same specified file

@VincenzoCarlino
Copy link
Contributor Author

Thanks, @VincenzoCarlino, we might need to test more cases such as if there's a PO file with the same specified file

Yes @hishamco , this is just an example of the structure of tests. Tomorrow I'll add more tests.

@hishamco
Copy link
Member

Please fix the build

@VincenzoCarlino
Copy link
Contributor Author

Hi @hishamco , I think that we don't have an easy way to test output files... using the real filesystem in the pipeline is not a good option. Do you have any suggestions?

@hishamco
Copy link
Member

Let me try ..

@VincenzoCarlino
Copy link
Contributor Author

Ok @hishamco I'll wait for your commit, let me know if I can do something.

@hishamco
Copy link
Member

Sorry for the late, I will struggle to have a look today because we need to finalize this and publish a release before Orchard Core 2.0.0

@VincenzoCarlino
Copy link
Contributor Author

Sorry for the late, I will struggle to have a look today because we need to finalize this and publish a release before Orchard Core 2.0.0

Hello, any update?
Thanks @hishamco

@hishamco
Copy link
Member

Seems I forgot this one, let me check it tonight if it's possible. My plan to publish a release ASAP and will be a part of OC 2.0.0

@hishamco
Copy link
Member

I suggest trying this PR from Program.cs then we can focus on make the CLI commands testable

@hishamco
Copy link
Member

@VincenzoCarlino please remove the changes in the test project, then I will merge, this not take so long to merge

@hishamco hishamco merged commit a24d198 into OrchardCoreContrib:main Aug 15, 2024
1 check passed
@hishamco
Copy link
Member

Thanks for your contribution @VincenzoCarlino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants