-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Lido contracts #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- CapManager Proxy
- CapManager Imple
- LidoARM Imple
- Zapper
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- CapManager Proxy - No constructor
- CapManager Imple
- LidoARM Imple
- Zapper
- The transactions that interacted with the newly deployed contract match the deploy script.
- Multisig tx matches the deploy script
Code Diff (against nicka/lp
branch)
- Cap Manager Proxy
sol2uml diff 0xf54ebff575f699d281645c6F14Fe427dFFE629CF .,node_modules -n mainnet
(node:60988) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "Proxy" contract with address 0xf54ebff575f699d281645c6F14Fe427dFFE629CF on mainnet
to local files under folders ".,node_modules"
match src/Ownable.sol
match src/Proxy.sol
- CapManager
sol2uml diff 0x8506486813d025C5935dF481E450e27D2e483dc9 .,node_modules -n mainnet
(node:60939) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "CapManager" contract with address 0x8506486813d025C5935dF481E450e27D2e483dc9 on mainnet
to local files under folders ".,node_modules"
match lib/openzeppelin-contracts-upgradeable/contracts/proxy/utils/Initializable.sol
match src/CapManager.sol
match src/Interfaces.sol
match src/Ownable.sol
match src/OwnableOperable.sol
- Lido ARM Impl
sol2uml diff 0x3d724176c8f1F965eF4020CB5DA5ad1a891BEEf1 .,node_modules -n mainnet
(node:61071) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "LidoARM" contract with address 0x3d724176c8f1F965eF4020CB5DA5ad1a891BEEf1 on mainnet
to local files under folders ".,node_modules"
match lib/openzeppelin-contracts-upgradeable/contracts/proxy/utils/Initializable.sol
match lib/openzeppelin-contracts-upgradeable/contracts/token/ERC20/ERC20Upgradeable.sol
match lib/openzeppelin-contracts-upgradeable/contracts/utils/ContextUpgradeable.sol
match lib/openzeppelin-contracts/contracts/interfaces/draft-IERC6093.sol
match lib/openzeppelin-contracts/contracts/token/ERC20/extensions/IERC20Metadata.sol
match lib/openzeppelin-contracts/contracts/token/ERC20/IERC20.sol
match lib/openzeppelin-contracts/contracts/utils/math/SafeCast.sol
match src/AbstractARM.sol
match src/Interfaces.sol
match src/LidoARM.sol
match src/Ownable.sol
match src/OwnableOperable.sol
- Zapper
sol2uml diff 0x01F30B7358Ba51f637d1aa05D9b4A60f76DAD680 .,node_modules -n mainnet
(node:60861) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "ZapperLidoARM" contract with address 0x01F30B7358Ba51f637d1aa05D9b4A60f76DAD680 on mainnet
to local files under folders ".,node_modules"
match src/Interfaces.sol
match src/Ownable.sol
match src/ZapperLidoARM.sol
|
DanielVF
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment
The mainnet deploy script is
script/deploy/mainnet/003_UpgradeLidoARMScript.sol
.This will update the contract addresses in
build/deployments-1.json
.Deployed Contracts
Etherscan
Governance
The following actions are in the governance tx:
This is tx #8 in the AMM v1 2/5 multisig
https://app.safe.global/transactions/tx?id=multisig_0xC8F2cF4742C86295653f893214725813B16f7410_0x4453fde153491aa4ded5f4956d8e2cdd2a7bfce73b2fe2864c6b7a1035595d30&safe=eth:0xC8F2cF4742C86295653f893214725813B16f7410
Deploy checklist
Two reviewers complete the following checklist: