feat/analytics #54
Closed
feat/analytics #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # pnpm-lock.yaml
move financial statement 'object' to front-end as a view query
usd/eth price switcher
style fix
show relative time, small -0% fix, style fix
export default
as a package, but doesn't abide by `@nx/enforce-module-boundaries`
abide by `@nx/enforce-module-boundaries`, converting packages to be buildable
toniocodo
reviewed
Sep 29, 2023
|
|
||
| export function TimeLineChart<FilterOption extends string>(props: { | ||
| title: string; | ||
| titleProps: ComponentProps<typeof Box>; |
There was a problem hiding this comment.
nit: you can use BoxProps directly
| @@ -21,6 +21,8 @@ export const theme = extendTheme({ | |||
| divider: '#101113', | |||
| background: { | |||
| paper: '#1E1F25', | |||
| paperHeader: '#23242A', | |||
| paperFooter: '#23242A', | |||
There was a problem hiding this comment.
I still think that having twice the same value with different keys makes very little sense. Maybe a more generic section field...
There was a problem hiding this comment.
🤷 neither header nor footer works for all usages
Merged
|
moved into #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibly obselete in favor of OriginProtocol/oeth.com#125