Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple governance actions #2368

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Jan 27, 2025

Change overview:

  • Split arbitrum deploy files into their own directory (extracted from BNB Setup #2366 since I will close that PR soon)
  • Add deployment files on Ethereum, Sonic and Base to grant the 5/8 Canceller role on the timelock
  • Add deployment file on Ethereum to remove OUSD AMO strategy

xOGN Governance: Grant Canceller Role to 5/8

xOGN Governance: Remove OUSD AMO Strategy

Base Timelock: Grant Canceller Role to 5/8

Sonic Timelock: Grant Canceller Role to 5/8

Copy link

github-actions bot commented Jan 27, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 48a5736

@shahthepro shahthepro changed the title Shah/governance actions branch Multiple governance actions Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.54%. Comparing base (1817476) to head (48a5736).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2368      +/-   ##
==========================================
- Coverage   52.53%   51.54%   -1.00%     
==========================================
  Files          91       91              
  Lines        4414     4414              
  Branches     1162     1162              
==========================================
- Hits         2319     2275      -44     
- Misses       2092     2136      +44     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahthepro shahthepro marked this pull request as ready for review January 27, 2025 16:09
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the following:

  • Mainnet proposal to grant canceller role to 5/8 Admin multi-sig
  • Mainnet proposal to remove OUSD AMO strategy
  • Base Timelock schedule and execute files to grant canceller role to 5/8 Admin multi-sig
  • Sonic Timelock schedule and execute files to grant Canceller role to 5/8 Admin multi-sig

@sparrowDom
Copy link
Member

I have verified:
Mainnet proposal to grant canceller role to 5/8 Admin multi-sig - ALREADY EXECUTED
Mainnet proposal to remove OUSD AMO strategy - ALREADY ALL SIGNED
Base Timelock schedule transaction to grant canceller role to 5/8 Admin multi-sig
Sonic Timelock schedule transaction to grant Canceller role to 5/8 Admin multi-sig

@shahthepro shahthepro merged commit 237d508 into master Jan 29, 2025
11 of 19 checks passed
@shahthepro shahthepro deleted the shah/governance-actions-branch branch January 29, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants