Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 116 - Upgrade OETH with Yield Forwarding. #2374

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Conversation

clement-ux
Copy link
Collaborator

@clement-ux clement-ux commented Jan 30, 2025

Deployment

Deploy script

  • 116_oeth_upgrade.js

Contracts

Contract Address
OETH Implementation 0x8309B55488500b7b062c849873717Bff8243061f

Governance

Proposal payload

[
  [
    "0x856c4Efb76C1D1AE02e20CEB03A2A6a08b0b8dC3"
  ],
  [
    {
      "type": "BigNumber",
      "hex": "0x00"
    }
  ],
  [
    "upgradeTo(address)"
  ],
  [
    "0x0000000000000000000000008309b55488500b7b062c849873717bff8243061f"
  ]
]
0xda95691a00000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000002200000000000000000000000000000000000000000000000000000000000000001000000000000000000000000856c4efb76c1d1ae02e20ceb03a2a6a08b0b8dc30000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001275706772616465546f28616464726573732900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000200000000000000000000000008309b55488500b7b062c849873717bff8243061f000000000000000000000000000000000000000000000000000000000000007b55706772616465204f45544820746f6b656e20636f6e74726163740a2020202020200a20202020202054686973207570677261646520656e61626c6564207969656c642064656c65676174696f6e20636f6e74726f6c6c656420627920784f474e20676f7665726e616e6365200a2020202020200a2020202020200000000000

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (abbccea) to head (80c84ef).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
+ Coverage   50.80%   50.98%   +0.17%     
==========================================
  Files          92       92              
  Lines        4513     4513              
  Branches     1195     1195              
==========================================
+ Hits         2293     2301       +8     
+ Misses       2217     2209       -8     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clement-ux clement-ux marked this pull request as ready for review January 30, 2025 14:18
clement-ux and others added 3 commits January 30, 2025 22:27
 into clement/deploy_116
@clement-ux clement-ux added deployment Deploying smart contract OETH OETH related things labels Jan 31, 2025
@naddison36
Copy link
Collaborator

naddison36 commented Feb 1, 2025

  • All deployed contracts are listed in the deploy PR's description
    • OETH
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal
sol2uml diff 0x8309B55488500b7b062c849873717Bff8243061f .,node_modules
Compared the "OETH" contract with address 0x8309B55488500b7b062c849873717Bff8243061f on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/token/OETH.sol
match   contracts/token/OUSD.sol

Sorry, something went wrong.

naddison36
naddison36 previously approved these changes Feb 1, 2025
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the deployment of the new OETH implementation to Mainnet

@sparrowDom
Copy link
Member

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • Contract constructors have correct arguments
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal
$ npx sol2uml diff 0x8309B55488500b7b062c849873717Bff8243061f .,node_modules
Compared the "OETH" contract with address 0x8309B55488500b7b062c849873717Bff8243061f on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/utils/math/SafeCast.sol
match   contracts/governance/Governable.sol
match   contracts/token/OETH.sol
match   contracts/token/OUSD.sol

Sorry, something went wrong.

@naddison36 naddison36 merged commit 61851c8 into master Feb 10, 2025
15 of 19 checks passed
@naddison36 naddison36 deleted the clement/deploy_116 branch February 10, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deploying smart contract OETH OETH related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants