Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy SwapX sonic Yield Forward #2386

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Feb 6, 2025

Yield forward

This PR forwards yield from the following SwapX pools to SwapX multisig addresses which will manually bribe the gauges.

  • SwapX OS/USDC.e pool to SwapX multisig
  • SwapX OS/GEMSx pool to SwapX multisig
Screenshot 2025-02-06 at 21 21 21

Deploy checklist

Two reviewers complete the following checklist:

- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.80%. Comparing base (46ba299) to head (795c37d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2386   +/-   ##
=======================================
  Coverage   50.80%   50.80%           
=======================================
  Files          92       92           
  Lines        4515     4515           
  Branches     1198     1198           
=======================================
  Hits         2294     2294           
  Misses       2217     2217           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparrowDom sparrowDom changed the title SwapX sonic Yield Forward Deploy SwapX sonic Yield Forward Feb 6, 2025
@naddison36 naddison36 added the deployment Deploying smart contract label Feb 6, 2025
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the following

  • Check the configured contract addresses are correct.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pool addresses and yieldTarget addresses are correct
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

@sparrowDom sparrowDom merged commit 22c3a7f into master Feb 8, 2025
18 of 23 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/sonic-swapx-yf branch February 8, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deploying smart contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants