-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy SwapX sonic Yield Forward #2386
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
=======================================
Coverage 50.80% 50.80%
=======================================
Files 92 92
Lines 4515 4515
Branches 1198 1198
=======================================
Hits 2294 2294
Misses 2217 2217
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified the following
- Check the configured contract addresses are correct.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Pool addresses and yieldTarget addresses are correct
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Yield forward
This PR forwards yield from the following SwapX pools to SwapX multisig addresses which will manually bribe the gauges.
Deploy checklist
Two reviewers complete the following checklist: