Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand OGV contracts and tweak Governance parameters #406

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Nov 20, 2023

Adds deploy_005 script that when executed will:

  • Deploy rebranded OGV and veOGV contracts and upgrade their proxies
  • Changes votingPeriod to 2 days with Blocks per seconds set to 12 (From the current value of 3 days with 15 bps which is way off)
  • Changes lateQuoromVoteExtension to 1 day (down from current value of 2 days)

Also, updates the common.py file to simulate execution of the proposal on fork


New Contracts

Name Address
OgvStaking 0xfd8e7dacc16c3807e66fedd4f7c65f26b1fee558
OriginDollarGovernance 0x190140d8d1815f6f92fd58df0dacb758276fffdb
- -
Deployer 0x58890a9cb27586e83cb51d2d26bbe18a1a647245
Proposer 0x6a6d776120f7e4a8dba5f6bf49b85cb340cfe241
Proposal Tx 0x9724611ddf5d1fc5e776a8e0c985d64e341857122582ab0fe362c72b445b232e
Proposal ID 22983443710848978447682038093447564105657898650006428914638357537618097496145

If you made a contract change, make sure to complete the checklist below before merging it in master.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@shahthepro shahthepro temporarily deployed to ousd-governa-shah-ogv-r-k9sof2 November 20, 2023 14:34 Inactive
@shahthepro shahthepro temporarily deployed to ousd-governa-shah-ogv-r-k9sof2 November 21, 2023 06:02 Inactive
@shahthepro shahthepro temporarily deployed to ousd-governa-shah-ogv-r-k9sof2 November 21, 2023 06:18 Inactive
@shahthepro shahthepro temporarily deployed to ousd-governa-shah-ogv-r-k9sof2 November 21, 2023 06:27 Inactive
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work

tests/test_token.py Show resolved Hide resolved
common.py Show resolved Hide resolved
@shahthepro shahthepro temporarily deployed to ousd-governa-shah-ogv-r-k9sof2 November 22, 2023 13:53 Inactive
@shahthepro shahthepro temporarily deployed to ousd-governa-shah-ogv-r-k9sof2 November 22, 2023 14:03 Inactive
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR and the governance proposal look OK

Copy link
Contributor

@DanielVF DanielVF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contract changes are good.

@shahthepro shahthepro merged commit 5a6ed04 into master Nov 27, 2023
3 checks passed
@shahthepro shahthepro deleted the shah/ogv-rebranding branch November 27, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants