-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand OGV contracts and tweak Governance parameters #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR and the governance proposal look OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contract changes are good.
Adds deploy_005 script that when executed will:
votingPeriod
to 2 days with Blocks per seconds set to 12 (From the current value of 3 days with 15 bps which is way off)lateQuoromVoteExtension
to 1 day (down from current value of 2 days)Also, updates the
common.py
file to simulate execution of the proposal on forkNew Contracts
If you made a contract change, make sure to complete the checklist below before merging it in master.
Contract change checklist: