Token merger deploy script #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Migrator contract * Fix some tests * Code review changes * Update OgvStaking tests * Disable delegation tests * Allow just unstakes * Fix comment * More cleanup * Fix brownie tests
DanielVF
reviewed
May 7, 2024
DanielVF
reviewed
May 7, 2024
DanielVF
reviewed
May 9, 2024
DanielVF
reviewed
May 9, 2024
| OUSD_BUYBACK_NEW_IMPL_ADDRESS = "0xdd753cb1fc4e8c72c5a40254ac064515301d11e0" | ||
| OETH_BUYBACK_NEW_IMPL_ADDRESS = "0x6c952cc410a253e70f3383028c7e0a7f477b921c" | ||
|
|
||
| def main(): |
There was a problem hiding this comment.
It would be good to have some sanity checking fork testing on this - these are fairly major changes.
I think we should also mint the new OGN to the migrator during this governance action. We can defer team funds for separate actions. But we still should fork test this migration + team funds + activating the migration and doing a migration.
There was a problem hiding this comment.
Have added a script that runs at the end of the deploy 006
|
Closing this, since we already have the Foundry scripts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you made a contract change, make sure to complete the checklist below before merging it in master.
Contract change checklist: