Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KC epoch created check #339

Conversation

Mihajlo-Pavlovic
Copy link
Collaborator

No description provided.

@Mihajlo-Pavlovic Mihajlo-Pavlovic self-assigned this Feb 3, 2025
Copy link
Contributor

@branarakic branarakic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also please replace the keyword CURATED with PERMISSIONED?
It's causing confusion, and once it is in contracts, it will stay there for a while @Mihajlo-Pavlovic

uint256 currentEpoch = chronos.getCurrentEpoch();
uint40 kcStartEpoch = kcs.getStartEpoch(knowledgeCollectionTokenId);

if (kcStartEpoch != currentEpoch && kcStartEpoch != currentEpoch) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double condition?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Mihajlo-Pavlovic Mihajlo-Pavlovic changed the base branch from v8-paranet-update to v8/ParanetIncentivesPool-rework February 13, 2025 11:16
@Mihajlo-Pavlovic Mihajlo-Pavlovic merged commit 8300953 into v8/ParanetIncentivesPool-rework Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants