Add telemetry

OrlaM · Jan 19, 2024 · 807d37c · 807d37c
1 parent 6ac73a7
commit 807d37c
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 1 deletion.
diff --git a/firefox-ios/Client/Coordinators/TabTray/RemoteTabsCoordinator.swift b/firefox-ios/Client/Coordinators/TabTray/RemoteTabsCoordinator.swift
@@ -46,6 +46,10 @@ class RemoteTabsCoordinator: BaseCoordinator,
     }
 
     func presentFxAccountSettings() {
+        TelemetryWrapper.recordEvent(category: .action,
+                                     method: .tap,
+                                     object: .syncSignIn)
+
         parentCoordinator?.didFinish(from: self)
         let urlString = URL.mozInternalScheme + "://deep-link?url=/settings/fxa"
         guard let url = URL(string: urlString) else { return }

diff --git a/firefox-ios/Client/Coordinators/TabTray/TabTrayCoordinator.swift b/firefox-ios/Client/Coordinators/TabTray/TabTrayCoordinator.swift
@@ -57,6 +57,9 @@ class TabTrayCoordinator: BaseCoordinator,
     }
 
     func start(panelType: TabTrayPanelType, navigationController: UINavigationController) {
+        TelemetryWrapper.recordEvent(category: .action,
+                                     method: .open,
+                                     object: .tabTray)
         switch panelType {
         case .tabs:
             makeTabsCoordinator(navigationController: navigationController)
@@ -104,12 +107,18 @@ class TabTrayCoordinator: BaseCoordinator,
 
     // MARK: - ParentCoordinatorDelegate
     func didFinish(from childCoordinator: Coordinator) {
+        TelemetryWrapper.recordEvent(category: .action,
+                                     method: .close,
+                                     object: .tabTray)
         remove(child: childCoordinator)
         parentCoordinator?.didDismissTabTray(from: self)
     }
 
     // MARK: - TabTrayViewControllerDelegate
     func didFinish() {
+        TelemetryWrapper.recordEvent(category: .action,
+                                     method: .close,
+                                     object: .tabTray)
         parentCoordinator?.didDismissTabTray(from: self)
     }
 }
diff --git a/firefox-ios/Client/Frontend/Browser/Tabs/Middleware/TabManagerMiddleware.swift b/firefox-ios/Client/Frontend/Browser/Tabs/Middleware/TabManagerMiddleware.swift
@@ -31,6 +31,7 @@ class TabManagerMiddleware {
             store.dispatch(TabPanelAction.didLoadTabPanel(tabState))
 
         case TabTrayAction.changePanel(let panelType):
+            self.trackPanelChange(panelType)
             let isPrivate = panelType == TabTrayPanelType.privateTabs
             let tabState = self.getTabsDisplayModel(for: isPrivate)
             if panelType != .syncedTabs {
@@ -112,6 +113,10 @@ class TabManagerMiddleware {
             store.dispatch(TabTrayAction.dismissTabTray)
 
         case RemoteTabsPanelAction.openSelectedURL(let url):
+            TelemetryWrapper.recordEvent(category: .action,
+                                         method: .open,
+                                         object: .syncTab)
+
             let urlRequest = URLRequest(url: url)
             self.addNewTab(with: urlRequest, isPrivate: false)
             store.dispatch(TabTrayAction.dismissTabTray)
@@ -225,6 +230,10 @@ class TabManagerMiddleware {
     ///   - originIndex: from original position
     ///   - destinationIndex: to destination position
     private func moveTab(from originIndex: Int, to destinationIndex: Int) {
+        TelemetryWrapper.recordEvent(category: .action,
+                                     method: .drop,
+                                     object: .tab,
+                                     value: .tabTray)
         defaultTabManager.moveTab(isPrivate: false, fromIndex: originIndex, toIndex: destinationIndex)
     }
 
@@ -400,4 +409,27 @@ class TabManagerMiddleware {
     private func tabPeekCloseTab(with tabID: String) {
         closeTabFromTabPanel(with: tabID)
     }
+
+    private func trackPanelChange(_ panel: TabTrayPanelType) {
+        switch panel {
+        case .tabs:
+            TelemetryWrapper.recordEvent(
+                category: .action,
+                method: .tap,
+                object: .privateBrowsingButton,
+                extras: ["is-private": false.description])
+        case .privateTabs:
+            TelemetryWrapper.recordEvent(
+                category: .action,
+                method: .tap,
+                object: .privateBrowsingButton,
+                extras: ["is-private": true.description])
+        case .syncedTabs:
+            TelemetryWrapper.recordEvent(category: .action,
+                                         method: .tap,
+                                         object: .libraryPanel,
+                                         value: .syncPanel,
+                                         extras: nil)
+        }
+    }
 }
diff --git a/firefox-ios/Client/Frontend/Browser/Tabs/Views/RemoteTabsPanel.swift b/firefox-ios/Client/Frontend/Browser/Tabs/Views/RemoteTabsPanel.swift
@@ -143,7 +143,6 @@ class RemoteTabsPanel: UIViewController,
     }
 
     private func handleOpenSelectedURL(_ url: URL) {
-        TelemetryWrapper.recordEvent(category: .action, method: .open, object: .syncTab)
         store.dispatch(RemoteTabsPanelAction.openSelectedURL(url))
     }
 }