login after we have run tests

Ortus-Solutions · Feb 7, 2025 · a659f4d · a659f4d
1 parent 78b75e8
commit a659f4d
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -163,13 +163,6 @@ jobs:
           echo "commandbox_version=${COMMANDBOX_VERSION}" >> $GITHUB_ENV
           echo "IMAGE_TAG=${TAGS}" >> $GITHUB_ENV
 
-      - name: DockerHub Login
-        if: github.event_name != 'pull_request'
-        uses: docker/login-action@v1
-        with:
-          username: ${{ secrets.DOCKER_USERNAME }}
-          password: ${{ secrets.DOCKER_PASSWORD }}
-
       - name: Test
         env:
           COMMANDBOX_VERSION: ${{ env.commandbox_version }}
@@ -180,7 +173,15 @@ jobs:
           docker compose -f docker-compose.test.yml up --build --exit-code-from sut
           docker compose -f docker-compose.secret-test.yml up --build --exit-code-from sut
 
+      - name: DockerHub Login
+        if: github.event_name != 'pull_request'
+        uses: docker/login-action@v1
+        with:
+          username: ${{ secrets.DOCKER_USERNAME }}
+          password: ${{ secrets.DOCKER_PASSWORD }}
+
       - name: Build Final
+        if: github.event_name != 'pull_request'
         uses: docker/build-push-action@v4
         env:
           DOCKER_BUILDKIT: 1