Add GitHub Action CI builds #1685
Conversation
The -dev is a Debian-specific suffix for indicating the source package. It's otherwise meaningless. You just grab something like https://github.com/hunspell/hunspell/files/2573619/hunspell-1.7.0.tar.gz and put the contents in an include path where it can find it. |
Well that hasn't been nearly as easy as it sounded. |
|
CMake being CMake, that'd have to be something like
Apologies, I assumed you were at ease with that kind of thing given this PR. :-) |
|
I have at least gotten MacOS to work now, and not given up on Windows yet. Also since the GitHub Actions don't have access to any sensitive information, you can just enable them for everyone (that doesn't have a fairly new GitHub account) under the "Actions" tab in the repository settings.
|
Try all major OS' with and without Hunspell Cache Qt Try building with Hunspell on Windows (fails)
|
I haven't been able to manually include hunspell. It is never able to find it for some reason. The failing Windows include hunspell code is in the last commit if someone wants to take a look. Otherwise the PR is as far as I want it to be. |
|
@JulianGro, sorry for late reply. |
Yup! :-) |
|
Anything keeping this from getting merged? |
| - name: Build Otter Browser | ||
| working-directory: ${{runner.workspace}}/build | ||
| shell: bash | ||
| run: cmake --build . --parallel 3 |
There was a problem hiding this comment.
I assume you based this on something, but I also assume GHA has a proper variable for it instead?
There was a problem hiding this comment.
I assume you mean the thread count? Yes: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
I don't think there is a GHA specific variable for the thread count, but my reasoning for that assumption is that you could just get the thread count from the system instead. We have 3 threads hardcoded on the Vircadia GHA which I adopted here.
There was a problem hiding this comment.
It just doesn't seem very forward thinking. I'd rather see for example $(nproc) or something along those lines. (Presumably this is nproc + 1; is that better somehow?)
There was a problem hiding this comment.
Now that you talk about
GHA doesn't have a variable for the available threads.
|
All looks pretty good to me in any case. ;) |
|
@JulianGro, for me the main issue is that I'm not really familiar with GHA yet… |
|
Well, you don't need to be. |
|
@JulianGro, but it helps, a lot, especially when it can be used to produce release binaries. |
|
@JulianGro, I've found someone that might help with this review, so hopefully I'll be finally able to deal with this PR. :-) |
This PR adds GitHub Action CI builds which automatically test incoming Pull Requests and commits to master on multiple Operating Systems and configurations.
Because of #1684 and because I haven't figured out how to install libhunspell-dev on Windows and MacOS, both of those don't work yet.
QtWebKit with Qt 5.15.2 also doesn't work because I haven't figured out how to install QtWebKit without installing Qt from APT as well.
For new contributors, you need to allow running GitHub Actions by opening the "Checks" tab and pressing the button on the top right.
I am up for maintaining this, and maybe even adding proper packaging and uploading in the future.