Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.9 #397

Merged
merged 5 commits into from
May 7, 2024
Merged

Prepare 0.9 #397

merged 5 commits into from
May 7, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented May 7, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • The newest xclim breaks our release of xscen, so we're due for an update.

Does this PR introduce a breaking change?

Other information:

@RondeauG RondeauG requested review from Zeitsperre and aulemahal May 7, 2024 17:32
@Zeitsperre
Copy link
Contributor

@RondeauG

It looks like the latest xclim breaks a few things (unsurprising; lots of small breaking changes because of mypy). You'll need to update to the latest xclim in a new PR, then rebase or merge this one onto it.

Don't apply fixes in here, or it'll trigger bump-my-version when you merge it!

@RondeauG RondeauG merged commit 59c9263 into main May 7, 2024
23 checks passed
@RondeauG RondeauG deleted the prep0.9 branch May 7, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants