Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix time coords issue #417

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix time coords issue #417

merged 1 commit into from
Jun 25, 2024

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Jun 25, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • When ds has time coords, but not dims, it passes the if statement but fails on the isel. Now, it just won't have a date_start , date_end

Does this PR introduce a breaking change?

no

Other information:

@juliettelavoie juliettelavoie requested a review from RondeauG June 25, 2024 18:37
@juliettelavoie juliettelavoie merged commit 52d32ad into main Jun 25, 2024
17 checks passed
@juliettelavoie juliettelavoie deleted the fix-updae-time-coords branch June 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliettelavoie @RondeauG