Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip as possible Zarr extenstion #426

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Zip as possible Zarr extenstion #426

merged 5 commits into from
Jul 4, 2024

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • The directory parser will now assign a "zarr" format to files with .zarr.zip or .zip extensions. The extension still needs to be included in the pattern.
  • get_engine returns zarr for the same two file extensions.

Does this PR introduce a breaking change?

No.

Other information:

@aulemahal aulemahal requested a review from Zeitsperre July 4, 2024 20:21
CHANGELOG.rst Outdated Show resolved Hide resolved
src/xscen/catutils.py Outdated Show resolved Hide resolved
src/xscen/catutils.py Outdated Show resolved Hide resolved
aulemahal and others added 2 commits July 4, 2024 16:34
@aulemahal aulemahal merged commit 93c9443 into main Jul 4, 2024
16 checks passed
@aulemahal aulemahal deleted the parse-zips branch July 4, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants