Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow CF convention for temperature difference #429

Merged
merged 15 commits into from
Nov 4, 2024
Merged

Follow CF convention for temperature difference #429

merged 15 commits into from
Nov 4, 2024

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Jul 12, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Add unit_metadata for the dtr conversion to be clear that this is a difference and not convert the units in a non-sensical way.
  • Added unit update for delta. If it's a temperature xclim will add the unit_metadata. Do we want this for the climatological delta ?

Does this PR introduce a breaking change?

yes, changes the attrs

Other information:

  • this needs to wait for the next xclim release for the new functions.
  • Should we add temperature: on_scale for tasmax_from_dtr and tasmin_from_dtr or is it unecessary?
  • Is it necessary somewhere else ?

RondeauG
RondeauG approved these changes Jul 12, 2024
View reviewed changes
@Zeitsperre Zeitsperre changed the title Follow CF convention for temperature differenre Follow CF convention for temperature difference Aug 8, 2024
@RondeauG RondeauG merged commit 4eaea42 into main Nov 4, 2024
16 checks passed
@RondeauG RondeauG deleted the fix-cf-temperature branch November 4, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cf conventions for dtr
2 participants
@juliettelavoie @RondeauG