-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Party Characteristics Tab and Visualizations to Dashboard #250
Conversation
…at caused Demographics to crash during site selection.
…at caused Demographics to crash during site selection.
…ist for proper processing
…rized endpoints for manager
… PartyCharacteristics
…re color-coded by 'lastYearEstimates', though currently the api is hardcoded to return the sum of 2018 estimates as 'lastYearEstimates'. Added turf package and update dependencies.
Thanks @davidye007! Cool to see the PR for this! @jblehr, curious to know if you have any ideas on a simple way to allow us to specify which projects display this data? As David mentioned currently any site with chatbot data will show these data visualizations. |
Also adding here that we talked about a couple additional improvements that we're leaving on the table for now. Specifically highlighting this one:
From this comment on west-cascades/issue159 |
Nice work @davidye007! One request before I get started on this: Can you please open (and link) the corresponding PR in That way, I can run this in dev mode on my computer to test it out. Or, is there a newer/better way for me to do test/review this? Edit: Also, other than @EmiliaH's request above, is there anything specific you'd like me to look at within this PR? |
@jblehr the chatbot data in I locally tested the |
…ites from Visitation and Visitor Characteristics.
… PartyCharacteristics
… ChatbotLocations
Updates made to |
…Site take site objects (unique) rather than trailNames. Fixed search bug by ensuring any duplicate trailNames are appended by trail id (unique).
…implementing event and function for site search highlight functionality
…highlight and pressing 'enter' on #{siteid} will work)
…rails-viz into chatbot_zipcode
…s-viz into chatbot_zipcode
Hey @jblehr, I just finished linting the code and the PR successfully passed the CI/CD checkpoints. Could you please check if the dashboard runs locally on your computer? To generate the chatbot data used by the dashboard, you can either:
Please let me know if you have any questions or concerns, thanks! |
Hey @davidye007, I'm confirming two things: I can run the dashboard locally on my computer (at least with firefox - I still run into CORS issues with chrome), and that it looks awesome! You've built a ton of stuff on here and it's especially cool to see the new data that shows which sites are receiving chatbot data. I just had one main comment/question on the chatbot home locations process: It seems like the chatbot home locations map and tree map functionality is identical to our generic "home locations" map and tree map functionality. And, my quick look at the code in several files shows significant duplication:
Further, within My main thought is: why can't we just use (more of) our existing home locations workflow and code to produce the home locations tree map and states/counties map? For example, for the I don't think this should hold up merging in this branch, but I'm curious to hear your thoughts and we can decide if it's worth creating an issue for this, etc. |
@jblehr Thank you for testing out the dashboard and for your brilliant suggestions! I really like your idea of merging the frontend components into a general I also like your idea of using the existing I think implementing the approaches you suggested will significantly reduce code duplication, as well as make it easier to add new data sources in the future. I'll create an issue for this! |
Implemented both API endpoints and UI for the Party Characteristics Tab:
Note: As of now, the Party Characteristics tab will show up for all available projects (assuming user has logged in and access to the Visitor Characteristics tab). In other words, any project that includes sites with chatbot data will have party characteristic visualizations available.
Currently, there isn't a way to toggle which projects have access to which tabs (e.g. Party Characteristics, Home Locations, Demographics). Though this could be a useful functionality for us to add.
Fixes #249
Fixes OutdoorRD/west-cascades#159