This repository has been archived by the owner on Aug 31, 2019. It is now read-only.
Tweaked a bit shell scripts #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes pushd and popd silent, uses log_* everywhere for improved visibility of errors, and uses wget if curl is not available (curl still has priority over wget).
Also I made clean.sh so that it returns the number of failed directory removals (so it's possible to chain commands like "./clean.sh && ./build.sh" so the second does not execute if the first fails)
I also removed cache directory from clean.sh. Cache is used solely for 1:1 copies of binaries from CDN. These files are never modified, and its MD5 is checked so corrupted files or modified are automatically removed and redownloaded when needed. Therefore there's no need to wait or waste bandwidth redownloading them once fetched.