Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for 1.5 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Temporary fix for 1.5 #3

wants to merge 1 commit into from

Conversation

lisanhu
Copy link

@lisanhu lisanhu commented Apr 15, 2024

Hi! Thanks for your great mod! I love it!

I tried to port it from 1.4 to 1.5 myself, it looks okay right now, however I haven't really tested it thoroughly, and there are many things changed in 1.5. Hope this will help you port easier.

Major changes:

  • I don't know how to ask the compiler to allow me to access some of the sealed members and private members, so I have to use reflection to get access to some of those, and harmony patches for some methods are changed to use strings instead of nameof. The DebugCell part of code in CleanPathfiningUtility.AdjustCosts has a check whether the cell is already flashed, however I don't know how to do it, so currently I just remove the condition checking and let it compile. Hopefully it will not affect normal use.
  • The glow grid is having a major change in its way to compute the glows in RW1.5, and I'm not sure I'm doing it correctly.
  • The cost of paths is changed from int to float due to 1.5 changes in CleanPathfiningUtility.AdjustCosts.

Look forward to seeing you back in 1.5 and I have subscribed a lot of your mods! You are great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant