[#4196] Move Rootbeer reporting to MainActivity (#4197)

Oztechan · Feb 4, 2025 · 571083c · 571083c
1 parent 41299a3
commit 571083c
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 23 deletions.
diff --git a/android/ui/mobile/android-ui-mobile.gradle.kts b/android/ui/mobile/android-ui-mobile.gradle.kts
@@ -65,6 +65,7 @@ dependencies {
             implementation(koinCompose)
             implementation(lifecycleRuntime)
             implementation(splashScreen)
+            implementation(rootBeer)
         }
 
         android.google.apply {

diff --git a/...ui/mobile/src/main/kotlin/com/oztechan/ccc/android/ui/mobile/content/main/MainActivity.kt b/...ui/mobile/src/main/kotlin/com/oztechan/ccc/android/ui/mobile/content/main/MainActivity.kt
@@ -18,10 +18,13 @@ import com.oztechan.ccc.android.core.ad.AdManager
 import com.oztechan.ccc.android.ui.mobile.BuildConfig
 import com.oztechan.ccc.android.ui.mobile.R
 import com.oztechan.ccc.android.ui.mobile.util.getThemeMode
+import com.oztechan.ccc.android.ui.mobile.util.isDeviceRooted
 import com.oztechan.ccc.android.ui.mobile.util.requestAppReview
 import com.oztechan.ccc.android.ui.mobile.util.resolveAndStartIntent
 import com.oztechan.ccc.android.ui.mobile.util.showDialog
 import com.oztechan.ccc.android.ui.mobile.util.updateBaseContextLocale
+import com.oztechan.ccc.client.core.analytics.AnalyticsManager
+import com.oztechan.ccc.client.core.analytics.model.UserProperty
 import com.oztechan.ccc.client.viewmodel.main.MainEffect
 import com.oztechan.ccc.client.viewmodel.main.MainViewModel
 import kotlinx.coroutines.flow.launchIn
@@ -34,6 +37,7 @@ class MainActivity : BaseActivity() {
 
     private val adManager: AdManager by inject()
     private val viewModel: MainViewModel by viewModel()
+    private val analyticsManager by inject<AnalyticsManager>()
 
     init {
         // use dark mode default for old devices
@@ -44,10 +48,16 @@ class MainActivity : BaseActivity() {
 
     override fun onCreate(savedInstanceState: Bundle?) {
         installSplashScreen()
+
         super.onCreate(savedInstanceState)
+
         Logger.i { "MainActivity onCreate" }
+
         setContentView(R.layout.activity_main)
+
         adManager.initAds(this)
+        analyticsManager.setUserProperty(UserProperty.IsRooted(isDeviceRooted(this)))
+
         observeStates()
         observeEffects()
     }

diff --git a/android/ui/mobile/src/main/kotlin/com/oztechan/ccc/android/ui/mobile/util/DeviceUtil.kt b/android/ui/mobile/src/main/kotlin/com/oztechan/ccc/android/ui/mobile/util/DeviceUtil.kt
@@ -10,6 +10,7 @@ import android.content.res.Resources
 import android.os.Build
 import androidx.appcompat.app.AppCompatDelegate
 import com.oztechan.ccc.client.core.shared.model.AppTheme
+import com.scottyab.rootbeer.RootBeer
 import java.util.Locale
 
 fun updateBaseContextLocale(context: Context): Context? {
@@ -22,6 +23,12 @@ fun updateBaseContextLocale(context: Context): Context? {
     }
 }
 
+fun isDeviceRooted(context: Context) = if (RootBeer(context).isRooted) {
+    true.toString()
+} else {
+    false.toString()
+}
+
 fun getThemeMode(appThemeValue: Int) = when (AppTheme.getThemeByValue(appThemeValue)) {
     AppTheme.LIGHT -> AppCompatDelegate.MODE_NIGHT_NO
     AppTheme.DARK -> AppCompatDelegate.MODE_NIGHT_YES

diff --git a/client/core/analytics/client-core-analytics.gradle.kts b/client/core/analytics/client-core-analytics.gradle.kts
@@ -20,10 +20,7 @@ kotlin {
             implementation(libs.common.test)
         }
         androidMain.dependencies {
-            libs.android.apply {
-                implementation(firebaseAnalytics)
-                implementation(rootBeer)
-            }
+            implementation(libs.android.firebaseAnalytics)
         }
     }
 }

diff --git a/...ics/src/androidMain/kotlin/com/oztechan/ccc/client/core/analytics/AnalyticsManagerImpl.kt b/...ics/src/androidMain/kotlin/com/oztechan/ccc/client/core/analytics/AnalyticsManagerImpl.kt
@@ -1,24 +1,16 @@
 package com.oztechan.ccc.client.core.analytics
 
-import android.content.Context
 import com.google.firebase.Firebase
 import com.google.firebase.analytics.FirebaseAnalytics
 import com.google.firebase.analytics.analytics
 import com.google.firebase.analytics.logEvent
 import com.oztechan.ccc.client.core.analytics.model.Event
 import com.oztechan.ccc.client.core.analytics.model.ScreenName
 import com.oztechan.ccc.client.core.analytics.model.UserProperty
-import com.oztechan.ccc.client.core.analytics.util.isDeviceRooted
 
-internal class AnalyticsManagerImpl(
-    context: Context
-) : AnalyticsManager {
+internal class AnalyticsManagerImpl : AnalyticsManager {
     private val firebaseAnalytics by lazy { Firebase.analytics }
 
-    init {
-        setUserProperty(UserProperty.IsRooted(isDeviceRooted(context)))
-    }
-
     override fun trackScreen(screenName: ScreenName) {
         firebaseAnalytics.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW) {
             param(FirebaseAnalytics.Param.SCREEN_NAME, screenName.getScreenName())

diff --git a/...ytics/src/androidMain/kotlin/com/oztechan/ccc/client/core/analytics/util/AnalyticsUtil.kt b/...ytics/src/androidMain/kotlin/com/oztechan/ccc/client/core/analytics/util/AnalyticsUtil.kt