-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aerosol Water Calculation #37
base: main
Are you sure you want to change the base?
Conversation
…tly IonPair attributes are hard-coded, future updates will move IonPair attribute assignment to AerosolModelData parsing.
…ghts are assigned via hard-coded map in TChem_ZSR.cpp wrapper, future behavior will access molecular weights from AerosolModelData instance attributes
…ementation does not allow accessing sub model attributes outside the scope of the initChem parser yet.
…encapsulating ion pair vector
…ssign state vector quantities to relevant indices, revise arguments to aerosol water team invoke method.
…molecular weights. Revise the name of the aerosol water type and add a 1-d dual view (tentative).
…out code for adding attributes to the aerosol model constant data subclass
…el data instead of ion_pair objects), compute aerosol water for all ionpair objects that are attributes of the aerowater_model class, remove code using a lookup dictionary for computing molecular weights with values assigned in the parser module.
…e arguments to aerosol_water_single_particle team invoke
…to assign various IonPair attributes with corresponding updated primitive types, add code for assigning a dual 1d view of the aerowater_params
…ew of ionpair objects. Add corresponding attributes under aerosolmodel_constdata
…ode for acessing data with primitive type attributes, use a switch for calculation type (jacobson or eqsam)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compiled this branch on my workstation with CUDA and encountered a few warnings (calling a __host__ function from a __host__ __device__ function
), which are due to std:: routines. Additionally, I encountered a compilation error that I have fixed. Please rebase your branch with the main branch.
…onditional statement to determine effective RH
…on (gases + aerosol species per particle), set arguments to team_invoke() to type const beside the state view
… other references to TChem's state variable.
…ter content [CURRENTLY FAILING]
…e_type, change state variable to value type (real type was incorrect)
…water values for each RH to aerowater view, copy from device to host and write values to file for comparison against host output
TChem_ZSR.cpp
(new wrapper script)IonPair
struct.state
variable instead of a general array data structure for assigning aerosol ICs.TChem_Util.hpp
modificationsIonPairs
struct for ZSR calculation attributes (e.g., parameters for calculation using either Jacobson or EQSAM method)AeroWater
struct (main struct for aerosol water calculations, encapsulates all of theIonPair
instances and indicates the parameter name for gas phase water and aerosol water)Potentially add AeroPhase struct for listing the name of species in the aerosol phase?TChem_AerosolModelData.cpp
modificationsIonPair
instancesAeroWater
struct for encapsulating parsed attributesTChem_AerosolModelData.hpp
modificationsTChem_Impl_SingleParticleAerosolWater.hpp
(new header file)TeamInvoke
method for calculating water contentAerosolModelData
attributes.