Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sftof file option to sea ice #1109

Merged
merged 35 commits into from
Dec 18, 2024
Merged

Add sftof file option to sea ice #1109

merged 35 commits into from
Dec 18, 2024

Conversation

acordonez
Copy link
Collaborator

@acordonez acordonez commented Aug 23, 2024

  1. Adds support to use model sftof or sftlf file for land/sea mask. File should use 0-1 for land sea fraction but the driver will attempt to identify when the mask uses 0-100 and convert it to 0-1. There is also an option to use no land/sea mask.
  2. Makes some minor fixes to figure appearance.
  3. Adds support for 360 day calendar (needed for CMIP3).
  4. Cleans up units adjustment tuples read from command line.
  5. Add annual mean maps.
  6. Updates the netcdf option: Files are written for use in generating figures, but if netcdf=False then the netcdf files are deleted at the end of the run.

@acordonez acordonez marked this pull request as ready for review October 30, 2024 21:52
@acordonez
Copy link
Collaborator Author

@lee1043 This PR has several options for using a land/sea mask file or generating it with the PMP. Should there also be an option to use no land/sea mask (i.e. if the user is confident the data is 0 or nan over land and wants to avoid the possibility of the land/sea estimate affecting results)?

@lee1043
Copy link
Contributor

lee1043 commented Oct 30, 2024

@lee1043 This PR has several options for using a land/sea mask file or generating it with the PMP. Should there also be an option to use no land/sea mask (i.e. if the user is confident the data is 0 or nan over land and wants to avoid the possibility of the land/sea estimate affecting results)?

I think that is a good idea! Did I suppose to review this PR? Sorry if that was slipped from my to do list. Please feel free to ping me.

@lee1043
Copy link
Contributor

lee1043 commented Oct 30, 2024

@acordonez oh, I see the PR was just converted to "ready for review" today. Sorry for the confusion. Please let me know when I can start reviewing.

@lee1043 lee1043 added this to the 3.7 milestone Oct 30, 2024
@acordonez acordonez requested a review from lee1043 October 30, 2024 23:42
@lee1043
Copy link
Contributor

lee1043 commented Oct 31, 2024

@acordonez no problem. Yes, please consider editing the sea-ice notebook. Could you remind me if we had sea-ice sample data downloadable as a part of demo 0 or as part of the sea-ice notebook?

@acordonez
Copy link
Collaborator Author

@acordonez no problem. Yes, please consider editing the sea-ice notebook. Could you remind me if we had sea-ice sample data downloadable as a part of demo 0 or as part of the sea-ice notebook?

I don't see any in my PMP data download, and I don't remember any being added.

@lee1043
Copy link
Contributor

lee1043 commented Nov 3, 2024

@acordonez thanks for reminding. I think there is a benefit to keep demo notebook as a standalone. Could you find a proper input data and add it to demo input data, and make it downloadable via either demo 0 or sea ice notebook, and use it throughout the notebook?

@acordonez acordonez marked this pull request as draft November 7, 2024 17:04
@lee1043 lee1043 modified the milestones: 3.7, 3.8 Nov 7, 2024
@lee1043
Copy link
Contributor

lee1043 commented Nov 7, 2024

@acordonez let me push this back to v3.8

@lee1043 lee1043 modified the milestones: 3.8, 3.9 Nov 26, 2024
@acordonez
Copy link
Collaborator Author

@lee1043 An update. I've found that the Demo sea ice notebooks are running on gates again (the E3SM data used seems to be back online). While we should update the notebooks to use data that users can download, that seems better suited to another PR. I think this one is ready to run and review.

@acordonez acordonez marked this pull request as ready for review December 12, 2024 00:25
@lee1043
Copy link
Contributor

lee1043 commented Dec 12, 2024

@acordonez thank you for the update. I agree, that downloadable demo data can be in another PR. I will review this next week. I think this can be released with v3.8.1, does that sound reasonable to you?

@acordonez
Copy link
Collaborator Author

@lee1043 That plan sounds good to me.

@lee1043
Copy link
Contributor

lee1043 commented Dec 17, 2024

@acordonez I updated the demo notebook to include the output directory named plot. After the update I found that the notebook run without any error. The PR is looking good to me. Thank you for your work!

@lee1043 lee1043 modified the milestones: 3.9, 3.8.1 Dec 18, 2024
@lee1043 lee1043 merged commit 7723ba2 into main Dec 18, 2024
4 checks passed
@lee1043 lee1043 deleted the ao_seaice_file_sft branch December 18, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants