Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB: Audio support for EyeToy / Konami ON-SAY microphone emulation #11715

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

Florin9doi
Copy link
Contributor

@Florin9doi Florin9doi commented Aug 16, 2024

Description of Changes

  • Merge Singstar and Logitech mics in a single device with 2 subtypes
  • Audio support for EyeToy
  • Konami On-Say microphone emulation / Jaleco Mic Converter / MTV Music Generator 2 Sampler Kit

Rationale behind Changes

Closes #4167, Closes #7626,

Suggested Testing Steps

@GitHub-Khi
Copy link

This will only partially close my #7626 report, right? Definitely a very good job for all these PRs. Respect - keep it up! :)

@Florin9doi
Copy link
Contributor Author

Florin9doi commented Aug 16, 2024

This will only partially close my #7626 report, right? Definitely a very good job for all these PRs. Respect - keep it up! :)

Yes, this PR will only fix the audio. The video issue is a duplicate for #4635. You can avoid it by using a webcam at 160x112 or OBS

@seta-san
Copy link
Contributor

japanese karaoke revolution is working and judging my singing harshly.

@prafullpcsx2
Copy link
Contributor

Thanks @Florin9doi
It works fine now. Also did a video showing this

https://youtu.be/9-75TGd2D9I?si=X7ASVKhsvVpxRz2U

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lightningterror lightningterror merged commit 777fc44 into PCSX2:master Aug 20, 2024
12 checks passed
@Florin9doi Florin9doi deleted the usb_mics branch August 20, 2024 08:10
@seta-san
Copy link
Contributor

i know this just got merged but at some point i think we lost the second player microphone on both the konami and singstar

@Florin9doi
Copy link
Contributor Author

Konami is a mono mic

@seta-san
Copy link
Contributor

Konami is a mono mic

no. it's got a second one. https://forums.pcsx2.net/attachment.php?aid=72457

@Florin9doi
Copy link
Contributor Author

@seta-san
Copy link
Contributor

okay. cool. i thought maybe the interface to the ps2 was stereo and each microphone took one of two channels. i don't know if two players was ever possible then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants