-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USB: Audio support for EyeToy / Konami ON-SAY microphone emulation #11715
Conversation
This will only partially close my #7626 report, right? Definitely a very good job for all these PRs. Respect - keep it up! :) |
japanese karaoke revolution is working and judging my singing harshly. |
Thanks @Florin9doi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some new compiler warnings to cleanup:
https://github.com/PCSX2/pcsx2/actions/runs/10442579076/job/28915025584?pr=11715#step:13:770
i know this just got merged but at some point i think we lost the second player microphone on both the konami and singstar |
Konami is a mono mic |
no. it's got a second one. https://forums.pcsx2.net/attachment.php?aid=72457 |
okay. cool. i thought maybe the interface to the ps2 was stereo and each microphone took one of two channels. i don't know if two players was ever possible then. |
Description of Changes
Rationale behind Changes
Closes #4167, Closes #7626,
Suggested Testing Steps