Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB: CaptureEye/OV511p webcam emulation #5382

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

Florin9doi
Copy link
Contributor

@Florin9doi Florin9doi commented Jan 22, 2022

Description of Changes

image

Suggested Testing Steps

@github-actions github-actions bot added the USB label Jan 22, 2022
@ghost
Copy link

ghost commented Jan 22, 2022

Better than the gameboy camera ^^.

VIDEOINFOHEADER* pVih = (VIDEOINFOHEADER*)pmtConfig->pbFormat;
pVih->bmiHeader.biWidth = frame_width;
pVih->bmiHeader.biHeight = frame_height;
pVih->bmiHeader.biSizeImage = DIBSIZE(pVih->bmiHeader);
hr = pSourceConfig->SetFormat(pmtConfig);
if (FAILED(hr))
{
Console.Warning("Camera: SetFormat err : %x", hr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice addendum to mention that the category is USB:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"USB:" isn't used anywhere in this file

Copy link
Contributor

@Mrlinkwii Mrlinkwii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Police 24/7 works great with the PR everything seems to be working as intended , checked some of the eyetoy games i own and saw no regressions 😄 , everything worked out of the box

@refractionpcsx2 refractionpcsx2 merged commit 45ba869 into PCSX2:master Jan 24, 2022
@Florin9doi Florin9doi deleted the ov511p branch January 24, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants