Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding several missings patches and corrected one. #301

Merged
merged 24 commits into from
Mar 2, 2024
Merged

Adding several missings patches and corrected one. #301

merged 24 commits into from
Mar 2, 2024
+323 −16

Conversation

backgamon
Copy link
Contributor

Adding several missings patches and corrected one.
All are tested working.

@backgamon
Adding several patches.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
8006ffc 
Adding missings patches and a corrected one.
@backgamon
Delete patches/SCES-50599_F5B07CC0.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
076b5f7
@backgamon
Add files via upload

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
879df1d
@backgamon
Update SLES-53623_9ADA98B4.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e28ab19
@backgamon
Update SLES-52280_E185C725.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
864eba4
@backgamon
Update SLUS-20837_78764E9C.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
a262a14
Mrlinkwii
Mrlinkwii reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@Mrlinkwii Mrlinkwii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments on the patches

@backgamon
Update SLES-52468_145DCFF7.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
91ee512
@backgamon
Update SLES-52589_89920FD9.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
9555e58
@backgamon
Update SLES-53156_9A03A3DD.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
112cf79
@backgamon
Update SLES-53623_9ADA98B4.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6b10081
@backgamon
Update SLES-52468_145DCFF7.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
87f9cee
@backgamon
Update SLES-52589_89920FD9.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
880dc0f
@backgamon
Update SLES-53156_9A03A3DD.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
033de25
@backgamon
Update SLES-53623_9ADA98B4.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c4a3f07
refractionpcsx2
refractionpcsx2 reviewed Feb 15, 2024
View reviewed changes
@backgamon
Update SLES-52468_145DCFF7.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f4f04e7
@backgamon
Update SLES-52589_89920FD9.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
68c0ac6
@backgamon
Update SLES-53156_9A03A3DD.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e49af79
@backgamon
Update SLUS-21474_18834BA2.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
370875a
@pgert
Copy link
Contributor

pgert commented Feb 16, 2024

You don't have to remove the 16:10 hacks, just change "gsaspectratio=16:10" into "gsaspectratio=Stretch".

@backgamon
Update SLES-52468_145DCFF7.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
b4bfa54
@backgamon
Update SLES-52589_89920FD9.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
afb171d
@backgamon
Update SLES-53156_9A03A3DD.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
db7752f
backgamon
backgamon commented Feb 17, 2024
View reviewed changes
Copy link
Contributor Author

@backgamon backgamon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected (again)

@pgert
Copy link
Contributor

pgert commented Feb 17, 2024 •
edited
Loading

If I'm not mistaken, it's case sensetive.
It has to be "Stretch", not "stretch".

Edit: Yes, it's case sensitive:
https://forums.pcsx2.net/Thread-Sticky-Important-Patching-Notes-1-7-4546-Pnach-2-0

@backgamon
Update SLES-52468_145DCFF7.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c95dc4a
@backgamon
Update SLES-52589_89920FD9.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
de05dda
@backgamon
Update SLES-53156_9A03A3DD.pnach

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
48962d2
@Mrlinkwii
Copy link
Contributor

whats the status of this PR?

@backgamon
Copy link
Contributor Author

whats the status of this PR?

I corrected all as requested.....

@refractionpcsx2 refractionpcsx2 merged commit 955a9d8 into PCSX2:main Mar 2, 2024
2 checks passed
@refractionpcsx2
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refractionpcsx2 refractionpcsx2

@pgert pgert

@Mrlinkwii Mrlinkwii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@backgamon @pgert @Mrlinkwii @refractionpcsx2