Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICO - formating, additions and improvements #434

Merged
merged 4 commits into from
Nov 11, 2024
Merged

ICO - formating, additions and improvements #434

merged 4 commits into from
Nov 11, 2024

Conversation

pgert
Copy link
Contributor

@pgert pgert commented Oct 19, 2024

No description provided.

@PeterDelta
Copy link
Contributor

PeterDelta commented Oct 19, 2024

20:9 and 21:9 aspect ratios cause game crashes

Ico_SCES-50760_20241019124244
Ico_SCES-50760_20241019124233
4:3 original

Ico_SCES-50760_20241019124823 20
Ico_SCES-50760_20241019124732 20
20:9

Ico_SCES-50760_20241019122854 21
Ico_SCES-50760_20241019122809 21
21:9


I see that in some you put "description" and below "comment". Everything that is put in a comment is irrelevant and will not be seen in the pcsx2 patches section when there is a "description", in the absence of a description what is put in the comment will be seen.
According to the changes of pnach 2.0, the new patches that are created change from comment to description, unless there is some plan that I am unaware of.

"comment" is the old format while "description" is the new format

@pgert
Copy link
Contributor Author

pgert commented Oct 20, 2024

Well crap. 20:9 & 21:9 removed.

@DrAzathoth
Copy link

DrAzathoth commented Oct 20, 2024

For the debug menu patch, including info about how to change the framerate is redundant thanks to the 60 fps patch. The 60 fps patch already forces the debug framestep value to 1 (and 2 during cutscenes) so even if the user tried to change it, there would be no effect.

For the 21:9/20:9 patch, I tried it out and didn’t get a single crash. Is it reproducible?

@pgert
Copy link
Contributor Author

pgert commented Oct 22, 2024

For the debug menu patch, including info about how to change the framerate is redundant thanks to the 60 fps patch. The 60 fps patch already forces the debug framestep value to 1 (and 2 during cutscenes) so even if the user tried to change it, there would be no effect.

I have made it into a non-displaying comment instaed.

For the 21:9/20:9 patch, I tried it out and didn’t get a single crash. Is it reproducible?

@PeterDelta ?

@PeterDelta
Copy link
Contributor

Reproducible? yes, but they are incomplete compared to the rest of the widescreen displays. This can be seen in the main menu itself.

@DrAzathoth
Copy link

Reproducible? yes, but they are incomplete compared to the rest of the widescreen displays. This can be seen in the main menu itself.

So, do you mean to say that there aren’t any crashes and only culling issues on the main menu and some cutscenes? I played through a vast chunk of the game and used the debug menu to skip to the end as well and encountered no crashes. Personally, I wouldn’t think culling would warrant an exclusion and aside from one or two cutscenes and the main menu (which are both extremely mild) I didn’t ever notice any culling issues.

@pgert, perhaps include the patch, but mention some mild culling beyond 16:9 during some scenes in the description?

@pgert
Copy link
Contributor Author

pgert commented Oct 26, 2024

There shouldn't be any problems with 16:10 & 15:10.
The hacks for 20:9 & 21:9 are a bit different than for 16:10 & 15:10,
and thats probably why there are imperfections.

@crashGG
Copy link
Contributor

crashGG commented Nov 6, 2024

Hi, bro, could you port these patches to SCPS-55001_29C28734 (Asian) and SCCS-4005_BF3A46DA (China) of Ico? Thank you very much!

@pgert
Copy link
Contributor Author

pgert commented Nov 6, 2024

Hi, bro, could you port these patches to SCPS-55001_29C28734 (Asian) and SCCS-4005_BF3A46DA (China) of Ico? Thank you very much!

No, I can't.
Try making a request at the forum:
https://forums.pcsx2.net/Thread-PCSX2-Widescreen-Game-Patches

@F0bes F0bes merged commit b33d454 into PCSX2:main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants