Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Fix the validation script #467

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

CookiePLMonster
Copy link
Contributor

This PR does the following:

  1. The validation script got some syntax warnings fixed and now explicitly reads the patch files as UTF-8. This makes the validation script work correctly also on Windows.
  2. Outdated actions have been updated. marvinpinto/action-automatic-releases is deprecated and should be replaced, but one of the possible replacements, softprops/action-gh-release, has its fair share of issues - and currently cannot be used by us properly due to generate_release_notes softprops/action-gh-release#191.

@F0bes F0bes merged commit b299e63 into PCSX2:main Jan 3, 2025
3 checks passed
@CookiePLMonster CookiePLMonster deleted the fix-validator-and-ci branch January 3, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants