make_trans_mutual to stop setting trans_parent on child if already se…

…t - #511
PDLPorters · Dec 24, 2024 · c908cf4 · c908cf4
1 parent 59dea4c
commit c908cf4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/PDL/Core/pdlapi.c b/lib/PDL/Core/pdlapi.c
@@ -732,7 +732,7 @@ pdl_error pdl_make_trans_mutual(pdl_trans *trans)
       child->state |= PDL_PARENTDIMSCHANGED | ((trans->flags & PDL_ITRANS_ISAFFINE) ? 0 : PDL_PARENTDATACHANGED);
       PDLDEBUG_f(printf("make_trans_mutual after change="); pdl_dump_flags_fixspace(child->state, 0, PDL_FLAGS_PDL));
     }
-    if (dataflow || wasnull[i]) child->trans_parent = trans;
+    if (!child->trans_parent || wasnull[i]) child->trans_parent = trans;
     if (wasnull[i])
       child->state = (child->state & ~PDL_NOMYDIMS) | PDL_MYDIMS_TRANS;
   }

diff --git a/t/core.t b/t/core.t
@@ -859,7 +859,7 @@ for ([\&float,\&cfloat,\&cdouble], [\&double,\&cdouble,\&cfloat], [\&ldouble,\&c
     is_pdl $o_cmplx, $ct->(0), 'current wrong answer from flowing, supplied output '.$rt->();
   }
   eval {czip($rt->(3)->flowing, $rt->(2), $ct->(0)->slice(''))};
-  is $@, '', 'current wrongly no error when supply output with parent to flowing';
+  is $@, '', 'current wrongly no error when supply output with parent to flowing '.$rt->();
   next if !$other_ct;
   czip($rt->(3)->flowing, $rt->(2), $o_cmplx = $other_ct->(0));
   is_pdl $o_cmplx, $other_ct->(0), 'current wrong answer from flowing, input '.$rt->().', supplied output '.$other_ct->();