Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add storage_account label #3

Merged
merged 1 commit into from
May 23, 2024
Merged

add storage_account label #3

merged 1 commit into from
May 23, 2024

Conversation

roelarents
Copy link
Contributor

Omschrijving

add storage_account label

also default metrics namespace to azure
also delete pdok specific config

https://dev.kadaster.nl/jira/browse/PDOK-16462

Type verandering

  • Nieuwe feature

Checklist:

  • Ik heb de code in deze PR zelf nogmaals nagekeken
  • Ik heb mijn code beter achtergelaten dan dat ik het aantrof
  • De code is leesbaar en de moeilijke onderdelen zijn voorzien van commentaar
  • Ik heb de tests toegevoegd/uitgebreid indien nodig
  • Ik heb de tests gedraaid die de werking van mijn wijziging bewijst
  • De PDOK documentatie is bijgewerkt indien nodig.
  • Er zit geen gevoelig informatie in deze PR (wachtwoorden etc)

@roelarents roelarents force-pushed the pdok-16462-account-label branch from bb2f8e3 to 3fb4f38 Compare May 23, 2024 12:11
@rkettelerij
Copy link
Collaborator

voorbeeld van metrics output in readme.md nog bijwerken

@roelarents roelarents force-pushed the pdok-16462-account-label branch from 3fb4f38 to 52aede7 Compare May 23, 2024 12:23
@roelarents roelarents requested a review from rkettelerij May 23, 2024 12:23
@roelarents roelarents force-pushed the pdok-16462-account-label branch from 52aede7 to 45382a5 Compare May 23, 2024 13:41
@roelarents
add storage_account label
8f1c8b0 
also default metrics namespace to azure
also delete pdok specific config

PDOK-16462
@roelarents roelarents force-pushed the pdok-16462-account-label branch from 45382a5 to 8f1c8b0 Compare May 23, 2024 13:45
@roelarents roelarents requested a review from rkettelerij May 23, 2024 13:46
@roelarents roelarents merged commit 891eca3 into master May 23, 2024
3 checks passed
@roelarents roelarents deleted the pdok-16462-account-label branch May 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbert2407 Robbert2407 Robbert2407 approved these changes

@rkettelerij rkettelerij rkettelerij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roelarents @rkettelerij @Robbert2407